linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] slab: fix include indentation
@ 2023-12-17  7:23 Parker, Amy
  2023-12-18  1:03 ` Song, Xiongwei
  0 siblings, 1 reply; 3+ messages in thread
From: Parker, Amy @ 2023-12-17  7:23 UTC (permalink / raw)
  To: cl, penberg; +Cc: linux-mm, linux-kernel

Include directives in slab are indented by tabs, except for
trace/events/kmem.h, which is indented with a single space.
This aligns in some editors depending on tab width setting,
but on others causes the directives to be misaligned.
This patch fixes that alignment.

Signed-off-by: Amy Parker <amyipdev@csu.fullerton.edu>

---
 mm/slab.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/slab.c b/mm/slab.c
index 9ad3d0f2d1a5..e09c44f5b5ac 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -125,7 +125,7 @@
 #include	<asm/tlbflush.h>
 #include	<asm/page.h>
 
-#include <trace/events/kmem.h>
+#include	<trace/events/kmem.h>
 
 #include	"internal.h"
 
-- 
2.43.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] slab: fix include indentation
  2023-12-17  7:23 [PATCH] slab: fix include indentation Parker, Amy
@ 2023-12-18  1:03 ` Song, Xiongwei
  2023-12-18  1:16   ` Parker, Amy
  0 siblings, 1 reply; 3+ messages in thread
From: Song, Xiongwei @ 2023-12-18  1:03 UTC (permalink / raw)
  To: Parker, Amy, cl, penberg, vbabka, 42.hyeyoo; +Cc: linux-mm, linux-kernel

> -----Original Message-----
> From: owner-linux-mm@kvack.org <owner-linux-mm@kvack.org> On Behalf
> Of Parker, Amy
> Sent: Sunday, December 17, 2023 3:23 PM
> To: cl@linux.com; penberg@kernel.org
> Cc: linux-mm@kvack.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] slab: fix include indentation
> 
> Include directives in slab are indented by tabs, except for
> trace/events/kmem.h, which is indented with a single space.
> This aligns in some editors depending on tab width setting,
> but on others causes the directives to be misaligned.
> This patch fixes that alignment.
> 
> Signed-off-by: Amy Parker <amyipdev@csu.fullerton.edu>
> 
> ---
>  mm/slab.c | 2 +-

The current slab allocator  is going to be removed.

https://lore.kernel.org/linux-mm/ZXEx1%2Fp9ejRmkVTS@localhost.localdomain/T/#m1a5899625baa61ad31a0e99eea6fc02258513ac1

Thanks.

>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/slab.c b/mm/slab.c
> index 9ad3d0f2d1a5..e09c44f5b5ac 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -125,7 +125,7 @@
>  #include       <asm/tlbflush.h>
>  #include       <asm/page.h>
> 
> -#include <trace/events/kmem.h>
> +#include       <trace/events/kmem.h>
> 
>  #include       "internal.h"
> 
> --
> 2.43.0



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] slab: fix include indentation
  2023-12-18  1:03 ` Song, Xiongwei
@ 2023-12-18  1:16   ` Parker, Amy
  0 siblings, 0 replies; 3+ messages in thread
From: Parker, Amy @ 2023-12-18  1:16 UTC (permalink / raw)
  To: Song, Xiongwei, cl, penberg, vbabka, 42.hyeyoo; +Cc: linux-mm, linux-kernel

> -----Original Message-----
> From: owner-linux-mm@kvack.org <owner-linux-mm@kvack.org> On Behalf
> Of Parker, Amy
> Sent: Sunday, December 17, 2023 3:23 PM
> To: cl@linux.com; penberg@kernel.org
> Cc: linux-mm@kvack.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] slab: fix include indentation
> 
> Include directives in slab are indented by tabs, except for
> trace/events/kmem.h, which is indented with a single space.
> This aligns in some editors depending on tab width setting,
> but on others causes the directives to be misaligned.
> This patch fixes that alignment.
> 
> Signed-off-by: Amy Parker <amyipdev@csu.fullerton.edu>
> 
> ---
>  mm/slab.c | 2 +-

> The current slab allocator  is going to be removed.

Hadn't gotten that news. Thanks for the update.

  - amyip

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-12-18  1:16 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-17  7:23 [PATCH] slab: fix include indentation Parker, Amy
2023-12-18  1:03 ` Song, Xiongwei
2023-12-18  1:16   ` Parker, Amy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox