From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96A27C48BC3 for ; Tue, 20 Feb 2024 12:11:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 034716B007B; Tue, 20 Feb 2024 07:11:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ED71C6B007D; Tue, 20 Feb 2024 07:11:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D027C6B0081; Tue, 20 Feb 2024 07:11:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id BB5476B007B for ; Tue, 20 Feb 2024 07:11:27 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 84CAEA07E1 for ; Tue, 20 Feb 2024 12:11:27 +0000 (UTC) X-FDA: 81812067414.08.8FA752C Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2043.outbound.protection.outlook.com [40.107.93.43]) by imf22.hostedemail.com (Postfix) with ESMTP id 718FAC000A for ; Tue, 20 Feb 2024 12:11:22 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b="tj42CD/c"; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf22.hostedemail.com: domain of ankita@nvidia.com designates 40.107.93.43 as permitted sender) smtp.mailfrom=ankita@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708431083; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P4UjTvDzAs55W0FV87nHPdGgw52PU9GedPe7X4sAa1k=; b=XQ0wUbAEO21oO4h0GylWbWFhNjqKYcFa/SBqHg4gY8yT5sEJww1bcCG6IgkPLuQBD8jJDE kzHvbWTV15GYM5IO+pxkwr+h2+0L017b/kCYvKtAwMYeiDyc3CHfay2JVif5w8GmS/2nzC FHyV3jDkaZeI/Z8ZMHnTo5AmqMbw2Ug= ARC-Authentication-Results: i=2; imf22.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b="tj42CD/c"; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf22.hostedemail.com: domain of ankita@nvidia.com designates 40.107.93.43 as permitted sender) smtp.mailfrom=ankita@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1708431083; a=rsa-sha256; cv=pass; b=FFVct0y8mZkwM8HzbOeOA9wwras3gTGdv72PcoztGifbr9xd7dTF8ugiRM12rWu6X/vgC0 qiwDQVkdwp3XmYyj5f0Q6347Et9xFQ99UVjKzoLecks7bkHtwOdaF2ZaX8vVY39WjgDGXX Sq6zuNn0u8wLWKUqM49R0m9kR+QfVRE= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XB7BY5GgvdueRpVustu3ea2YhczxIRapc1PTn9zEuzNODxicM71oKC5csWa+QPrP8KMg//oo22HMrvOuL1soPwBgy8PMCs+vDf5fphcPHMtTqm/GRNo9vpgSZ6SkJkfR12TTkeTxsJxAf9N1vYVDjkQFNNP/87Yd+olG34wKMhOBXPlDsbUENmT1PqMLiwtmYaJacCc1MKjpDCeVJhhOP6R1q6K7mNSlKsfbpBb3FkIATLSb1PxIxQI5nLmH+/Q3FYqtF1TJHMEa7ScNQG3RWBtDBJp5OpExC6kus++Ucp6YOvWfvrKQXmJwv/DiHeI7V+v/JOLhAJ3APH6JbY2Jgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P4UjTvDzAs55W0FV87nHPdGgw52PU9GedPe7X4sAa1k=; b=lV8Xk6ak6Kzeu6fIhzkpS9QTZ433GyW/rqbhJ1GLgtT2Pf0L+7BiKNeeHxGgrbWBWlJf5FIh+/unDTmNETbCTzpiQcEMVGRAfH3usuGXZkyztHWuorYHGlQBuSe8kkGP5UuIg7ZXKofE0iDPkgGxhCiSoXiOWsUZAFt9G0N7V61W32JQH+nrYL+23qS/kO1/MHUfXgwv+auHZN0dRWGFwa/AQnAY3K9I7xHyIjhEu+1PSVbL60p/HeyWvCQLoUhXywbmCNLqrLs8i+d3WAc7yuFrLZfgJp8vHZwsj6BQm8s3R1WXOfaGNQPiicfRSoppcktipeP13XwhMv+DHzJgDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P4UjTvDzAs55W0FV87nHPdGgw52PU9GedPe7X4sAa1k=; b=tj42CD/cWmCn+8W+KnrJQBTWtqbIbYOZXNHIvOEECaQgoVO5JcuB0TofRW3XkBu5rmX0XTGRpi1+FA3eDbGz+c+LLso+nmRKoJNxt30u70YXgWM2Z9EYvPTDpCTAoFOBODPB/ObGn7EVqVZl//ZbJjXSbuzXEx5hIZ02YO9kYkubEtjDQOZE05XpRqzHSDHJiZP3chKCFzoAzwTVxoymMAgLbemI+lbS2pOydZkv5ZyC/9J1ShexSCilEt/c4uH8uHbkpJJ86LrVJz6OFG7bUcpGYzYXmyHZLRxrdE9fF9kSXPo3+qMgK/0/Zy+oL1XQNAdLlWjTBt+vWItqbQk5dQ== Received: from SA1PR12MB7199.namprd12.prod.outlook.com (2603:10b6:806:2bc::21) by SJ2PR12MB8033.namprd12.prod.outlook.com (2603:10b6:a03:4c7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.17; Tue, 20 Feb 2024 12:11:19 +0000 Received: from SA1PR12MB7199.namprd12.prod.outlook.com ([fe80::284c:211f:16dc:f7b2]) by SA1PR12MB7199.namprd12.prod.outlook.com ([fe80::284c:211f:16dc:f7b2%5]) with mapi id 15.20.7316.016; Tue, 20 Feb 2024 12:11:19 +0000 From: Ankit Agrawal To: Catalin Marinas CC: Jason Gunthorpe , "maz@kernel.org" , "oliver.upton@linux.dev" , "james.morse@arm.com" , "suzuki.poulose@arm.com" , "yuzenghui@huawei.com" , "reinette.chatre@intel.com" , "surenb@google.com" , "stefanha@redhat.com" , "brauner@kernel.org" , "will@kernel.org" , "mark.rutland@arm.com" , "alex.williamson@redhat.com" , "kevin.tian@intel.com" , "yi.l.liu@intel.com" , "ardb@kernel.org" , "akpm@linux-foundation.org" , "andreyknvl@gmail.com" , "wangjinchao@xfusion.com" , "gshan@redhat.com" , "shahuang@redhat.com" , "ricarkol@google.com" , "linux-mm@kvack.org" , "lpieralisi@kernel.org" , "rananta@google.com" , "ryan.roberts@arm.com" , "david@redhat.com" , "linus.walleij@linaro.org" , "bhe@redhat.com" , Aniket Agashe , Neo Jia , Kirti Wankhede , "Tarun Gupta (SW-GPU)" , Vikram Sethi , Andy Currid , Alistair Popple , John Hubbard , Dan Williams , "kvmarm@lists.linux.dev" , Matt Ochs , Zhi Wang , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v8 4/4] vfio: convey kvm that the vfio-pci device is wc safe Thread-Topic: [PATCH v8 4/4] vfio: convey kvm that the vfio-pci device is wc safe Thread-Index: AQHaY87ElOqCfNqv40aGQwk3/xRuTbES/mYAgAAlXLw= Date: Tue, 20 Feb 2024 12:11:19 +0000 Message-ID: References: <20240220072926.6466-1-ankita@nvidia.com> <20240220072926.6466-5-ankita@nvidia.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR12MB7199:EE_|SJ2PR12MB8033:EE_ x-ms-office365-filtering-correlation-id: e692da57-0405-4c67-b750-08dc320d0ba1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KGHzGTQs/2Dz7FZYgEKbRzWTuXmbDdP6zEW7zSSPVoOVjdVixX6kAhBu6JGweUtss0+w21wpeM9qx/3lDxz9HaFRBAfUNDAnrdZ5obrmi5UMIDjxWAD5cmD6unO5h22JQST6JcEzK7OggkiGG7U+tom9JXr/KqgglMm2MwD9ukCddM2RCmcGm2LhqesOYzm6peUvyy20Zlb9eh125HeDojHfa3cXsgegm5Yzcy7AEnYLZE077Ah77pLeaPPWHRYdg8ixzQTBFIqeWuKuhzpAx5l3BPpZgQGo74p8Mtz73V24+L3zpWbcGnBXNzklwHlte5BXFMynDNCncXrFniB/yTVumMZSnasNCXklha0EiNINVx0g4VFwT5AackzglA2G/iU+0n1VAQmlr1FriRDJNrMxmSWLWkByCog7h77/Bjr06SCGlmnTsOBAq1e0xjM8SPDrOjkK+sMLE3g4vRRGgiibk3zNqJhPRKx7KZWaa/Z+sEKIRGH2J2itXhaY4ILUKqv8tT5F/SEQEsjw6ixMhHYyacOlRjJVRm4gkj9ISZV1rQQbp7Ee5CkGj//SJXQC4IbxxmtymkKwVp1W6mUJ921bFf1cFgPS+Na9vAr89FxTC2hH1jRidgiprdrE8RaV x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR12MB7199.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(38070700009);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?KBdNgNHTc/49SJJ2Fho8kLr7/J3apB8BXy6EaKvgAul/ZtPfPsEaqXzAvr?= =?iso-8859-1?Q?WefO1J2l3w63kIc9Hthnwd3CPkiA6WBXApylwClbJYuMgBwTFOoIjK3gTU?= =?iso-8859-1?Q?GOgZOKZESi76k3zZQByaqVS49/Cs5X8397opdbc2PdFOwyZTuryW66S5Ww?= =?iso-8859-1?Q?51ilyyzgv5P+gptnYqoe4iNniobGnBZhCgeiN/qj71CVnAEtqJw01JFcZ9?= =?iso-8859-1?Q?uhlpgdM2QAlvyP/fli8pvo6aCRxrG4540wDnJflaAMKkhS9OtCd83CFfxu?= =?iso-8859-1?Q?dI63HxsJIfMmLjaN2n2qRttWaj2LsExPPW6WA2HsDSgXssTpRWNAeX/jG+?= =?iso-8859-1?Q?Pkd7w1U9bYRBp+EKLvZGXmcSVW2GAhWIXT5z3DkmBCFLi3/P+v5GZq9vU2?= =?iso-8859-1?Q?NkOSzfCscE4yuHFGG02d2JkIZSFzLnP8CSTteInSRvIRNn+fI/PAnsMzOp?= =?iso-8859-1?Q?pon/ikig3zJk6/caGEQYUZQmnFaY5traDFCZRxuPifx74hcWvtmZsvCYSM?= =?iso-8859-1?Q?431DXYJ7l5cycTP1X+ng5qiMG32Z/WeAbeyrk7Hk+faXx7aMkozNH2/rIQ?= =?iso-8859-1?Q?v475HQ59eQGRN/q0Ku+1uyYWSMwnIkvQNIalc7RvK2kyD4gbk91TdoYzIm?= =?iso-8859-1?Q?/AvI3gH8S14U1xw9po1rL3qrW5L24Uhf2J3m+flrjhFk9TXmYyOkv/BoWA?= =?iso-8859-1?Q?v2mAuvnkdRKy17M8ItQfhTxxQKNZVNVJf044JjoioaNduz8E4xbVCgtSGc?= =?iso-8859-1?Q?msONQ6dfMr4jhraXke8COsamJKIrxG+M0LgwRhjk4CZuZOQLXgScIVGaSY?= =?iso-8859-1?Q?0c4v4TfkGIqpy3d2Wemc7VJNtjtqY8PY7n9u3t7e0Pn2UWu/p3ULTa7GYG?= =?iso-8859-1?Q?14j/ggZMjcKGfGoqEPIWoDby9sSZCUoBKC2+VG5Z4IvCkvknU1dyDufFbw?= =?iso-8859-1?Q?H4sorCKFzPCMYkq0Aq+Q8will3vogoepo9w1MoQ0/4b7d3vIUJJeWhyMDO?= =?iso-8859-1?Q?l5zyiV2Kd0ZaW8w7A+J/M1MuO5ekSwV5JQ0+zFBpaI7wTWPupEifs6aS/r?= =?iso-8859-1?Q?Od5fxHfXTZu2MWFgb8QAIkgAvqffdCYtY/t8n7lR/lD+cwkOsWSL55FCKg?= =?iso-8859-1?Q?sXJQE5LlONUydi73p7684lC3hLy63Ip1BhevHzKq78Mp3QYBjUUmfkslMu?= =?iso-8859-1?Q?vkzb0YpmiJ7J2lYtlecsHDeQqzw4eBmijRfkgVwu6t/R2S2giycw6Pdqfd?= =?iso-8859-1?Q?MbeeYlyzXAkhFwJKZNS+SvLdyN2cmiWfQd/qk85qYoq+yhfJyA0JfVrKQ7?= =?iso-8859-1?Q?Z1MueZzddNCw0VPMhtdaYsGbH6+3Fb4SbTu2nNYglo9I6B7lsThzHGOUBM?= =?iso-8859-1?Q?eGCaB3IcVP3TK5Y14MtomAT0VInKRG1UuU3jbcg3BUfpvP0lK70UrQkJl5?= =?iso-8859-1?Q?AkGFA7UQwRx6fe5RVMEulBTG+7WNFvgSPLGVr0W/D23imseRxhxFzFwE1k?= =?iso-8859-1?Q?21H8UUSeEPG/VT2iUw7V6r/grLZD3puberUvG0cOKQppMB7EVQwLwvSUSa?= =?iso-8859-1?Q?AMm2sWHBIO9JzHQXXsx/YrMIcUtkikSTFXSCjo+5vyRSgkXW1QbvXqN5Yc?= =?iso-8859-1?Q?timS8yGcgCJKk=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR12MB7199.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e692da57-0405-4c67-b750-08dc320d0ba1 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2024 12:11:19.0672 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Fr1TZiiGwCJqTwdKtjO2H08f1+sf2fuRlOtTPVtxQ/7X7qFgIkIYYHsBc1k0m/vmu+aMzwcoxNC8aCBiSXZ7Ww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8033 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 718FAC000A X-Stat-Signature: cuxpyyozjk8h5ujfb3z93678hfuzzz8o X-Rspam-User: X-HE-Tag: 1708431082-609524 X-HE-Meta: U2FsdGVkX1964jNembs8EChb0W2iz5P2gO/BFju6SeQ+TviWESPN4sgkxwPXQ6bhqseod+c7CIwkUY1bzb9z5jj/b6ikDYMGVjI6AY6Y6iKj2f9N9InSM5FLgOgPLK8zU4+Iat0Jr98yOGAUeeXQLOSRgx2DNcQTOcosGIguQ/xtYlvOCH7+4h1GsUq9JmMY6odiCc0bzwTn6E/8HYufD8MW/WHXfr1lYaqfhcndzTHeql9AyN0hcXjo0E0qriIUZTgXHKpuAtWNQmvPVLdOv2AipxeeJnWt1ZZRqLivuss1v+t57kMyutJKxOI7yYWA4SakFKl9S35ZEw7qG/A3+hs0yWNd9MoTL1y6fhEtbgoCfBFt4ETqWfCitV4LqXnXLAOb2ZOcQJa1azrKtUyVWbOoD8feSB39IDKep/DLVNa1W0Dj/+xYsqclRTwjFixMz9lA2FqQj4XsJSXMZh45oVtIv0FsEAohBc5Ntiz4YQRUI3e2cM8psvgB7WalX/P5Ly3hv8qoOwnqqIEJbz7zLtearStkbEfYecAT+F6Agx8dSu7pDAe66Dc5xA5+Xt3qIuf9HRxu+nAVTeVKZs1azZa671LWVmUfFmvikrrW+vaeLtbsUy2TeerZovn7yGDV+xG2kQCggFEC6dGuDv68hI90984oJlG2jRqwmrrTAjOmWQ3vwWldrbPQMmgy7HDkeCs6pltYH88MNL2k096QYlYe/hwQdjLMWbnYdQVKl/GW4gSTZ0pXjnnVEDvwT/RPLsVmWqgbuYiRDErqvtbl+f8fVe58XnmbFwwAz9UyOuFQT9AP9Nds6DVf3Km5bMT0Zzut6/lO7XdghAL4HGvBprHpaTw7c8rtGP7wE1Lha8LF88BMZnKE8Y+P/ySi/xtQ317D6o9M9nffvoAm9AEIni7Nq7r+Np7i6+9dEBCs2uS/tdWqXRnQM7CAODYLQXnx3i323JifhjLSIjwlapI c34tYtMi C85dXcP/QcPOGA78WSxyEBJg5lFF1rcHFMr4M8IXP4deLCuALNJBZDifoK/Mm6KAO5k191DO0F152JVIqzgIU+gW007uAZP3vDOL2Z46TGQE11uGGvb/Fgzr7HHlMgwftgV4Fo5s7HFQacTUEvqADhxSdbPCRTvXP5c7RUil7XOVunkWVBKnfmMAVs9/aOr8i6t+6sGs2K1wzALfZlalZlC4gdWbKqUZMpGap3PgSY1JsbXs39v9CvsaDwpynqBCCqs4geba+dT1m2U6uOMT+gImoLHqWC77Bd5yFCbDsBUIOJxs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pc= i_core.c=0A= >> index 1cbc990d42e0..c93bea18fc4b 100644=0A= >> --- a/drivers/vfio/pci/vfio_pci_core.c=0A= >> +++ b/drivers/vfio/pci/vfio_pci_core.c=0A= >> @@ -1862,8 +1862,24 @@ int vfio_pci_core_mmap(struct vfio_device *core_v= dev, struct vm_area_struct *vma=0A= >>=A0=A0=A0=A0=A0=A0 /*=0A= >>=A0=A0=A0=A0=A0=A0=A0 * See remap_pfn_range(), called from vfio_pci_fault= () but we can't=0A= >>=A0=A0=A0=A0=A0=A0=A0 * change vm_flags within the fault handler.=A0 Set = them now.=0A= >> +=A0=A0=A0=A0=A0 *=0A= >> +=A0=A0=A0=A0=A0 * VM_ALLOW_ANY_UNCACHED: The VMA flag is implemented fo= r ARM64,=0A= >> +=A0=A0=A0=A0=A0 * allowing KVM stage 2 device mapping attributes to use= Normal-NC=0A= >> +=A0=A0=A0=A0=A0 * rather than DEVICE_nGnRE, which allows guest mappings= =0A= >> +=A0=A0=A0=A0=A0 * supporting combining attributes (WC). ARM does not=0A= >=0A= > Nitpick: "supporting write-combining" (if you plan to respin).=0A= =0A= Ack.=