linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Ankit Agrawal <ankita@nvidia.com>
To: Jiaqi Yan <jiaqiyan@google.com>
Cc: Vikram Sethi <vsethi@nvidia.com>,
	Jason Gunthorpe <jgg@nvidia.com>, Matt Ochs <mochs@nvidia.com>,
	"jgg@ziepe.ca" <jgg@ziepe.ca>,
	Shameer Kolothum <skolothumtho@nvidia.com>,
	"alex@shazbot.org" <alex@shazbot.org>,
	"linmiaohe@huawei.com" <linmiaohe@huawei.com>,
	"nao.horiguchi@gmail.com" <nao.horiguchi@gmail.com>,
	Neo Jia <cjia@nvidia.com>, Zhi Wang <zhiw@nvidia.com>,
	Krishnakant Jaju <kjaju@nvidia.com>,
	Yishai Hadas <yishaih@nvidia.com>,
	"kevin.tian@intel.com" <kevin.tian@intel.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH v1 2/2] vfio/nvgrace-gpu: register device memory for poison handling
Date: Thu, 8 Jan 2026 19:21:22 +0000	[thread overview]
Message-ID: <SA1PR12MB7199A597C97F6A0DD4413799B085A@SA1PR12MB7199.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CACw3F52rHjxv8gWzz6_YdR038CiA1=JxUD6YuW4As=rQ2oMdag@mail.gmail.com>

>> +static inline
>> +struct nvgrace_gpu_pci_core_device *vma_to_nvdev(struct vm_area_struct *vma);
>
> Any reason not to define vma_to_nvdev() here directly, but later?

Actually since it uses nvgrace_gpu_vfio_pci_mmap_ops; which the compiler
complains to be undeclared if vma_to_nvdev is moved up.

>> +       ret = register_pfn_address_space(&region->pfn_address_space);
>> +
>> +       return ret;
>
> nit: I believe "ret" is unnecessary here.

Yes, I'll address that.

      reply	other threads:[~2026-01-08 19:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-08 15:35 [PATCH v1 0/2] Register " ankita
2026-01-08 15:35 ` [PATCH v1 1/2] mm: add stubs for PFNMAP memory failure registration functions ankita
2026-01-08 15:35 ` [PATCH v1 2/2] vfio/nvgrace-gpu: register device memory for poison handling ankita
2026-01-08 17:00   ` Jiaqi Yan
2026-01-08 19:21     ` Ankit Agrawal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SA1PR12MB7199A597C97F6A0DD4413799B085A@SA1PR12MB7199.namprd12.prod.outlook.com \
    --to=ankita@nvidia.com \
    --cc=alex@shazbot.org \
    --cc=cjia@nvidia.com \
    --cc=jgg@nvidia.com \
    --cc=jgg@ziepe.ca \
    --cc=jiaqiyan@google.com \
    --cc=kevin.tian@intel.com \
    --cc=kjaju@nvidia.com \
    --cc=kvm@vger.kernel.org \
    --cc=linmiaohe@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mochs@nvidia.com \
    --cc=nao.horiguchi@gmail.com \
    --cc=skolothumtho@nvidia.com \
    --cc=vsethi@nvidia.com \
    --cc=yishaih@nvidia.com \
    --cc=zhiw@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox