From: Ankit Agrawal <ankita@nvidia.com>
To: Miaohe Lin <linmiaohe@huawei.com>
Cc: Neo Jia <cjia@nvidia.com>, Zhi Wang <zhiw@nvidia.com>,
Krishnakant Jaju <kjaju@nvidia.com>,
Yishai Hadas <yishaih@nvidia.com>,
"kevin.tian@intel.com" <kevin.tian@intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Vikram Sethi <vsethi@nvidia.com>,
Jason Gunthorpe <jgg@nvidia.com>, Matt Ochs <mochs@nvidia.com>,
"jgg@ziepe.ca" <jgg@ziepe.ca>,
Shameer Kolothum <skolothumtho@nvidia.com>,
"alex@shazbot.org" <alex@shazbot.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"nao.horiguchi@gmail.com" <nao.horiguchi@gmail.com>
Subject: Re: [PATCH v2 1/3] mm: fixup pfnmap memory failure handling to use pgoff
Date: Wed, 17 Dec 2025 18:10:34 +0000 [thread overview]
Message-ID: <SA1PR12MB7199065CD785B5FD0BFE6FB9B0ABA@SA1PR12MB7199.namprd12.prod.outlook.com> (raw)
In-Reply-To: <f871d90d-11e0-1719-c946-1c0bf341042a@huawei.com>
>> i_mmap_lock_read(mapping);
>> rcu_read_lock();
>> @@ -2226,9 +2230,12 @@ static void collect_procs_pfn(struct address_space *mapping,
>> t = task_early_kill(tsk, true);
>> if (!t)
>> continue;
>> - vma_interval_tree_foreach(vma, &mapping->i_mmap, pfn, pfn) {
>> - if (vma->vm_mm == t->mm)
>> - add_to_kill_pfn(t, vma, to_kill, pfn);
>> + vma_interval_tree_foreach(vma, &mapping->i_mmap, 0, ULONG_MAX) {
>> + pgoff_t pgoff;
>
> IIUC, all vma will be traversed to find the final pgoff. This might not be a good idea
> because rcu lock is held and this traversal might take a really long time. Or am I miss
> something?
Hi Miaohe, the VMAs on the registered address space will be checked. For the nvgrace-gpu
user of this API in 3/3, there are only 3 VMAs on the registered address space (that are
associated with the vfio file).
next prev parent reply other threads:[~2025-12-17 18:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-13 4:47 [PATCH v2 0/3] mm: fixup pfnmap memory failure handling ankita
2025-12-13 4:47 ` [PATCH v2 1/3] mm: fixup pfnmap memory failure handling to use pgoff ankita
2025-12-17 3:10 ` Miaohe Lin
2025-12-17 18:10 ` Ankit Agrawal [this message]
2025-12-18 2:18 ` Miaohe Lin
2025-12-13 4:47 ` [PATCH v2 2/3] mm: add stubs for PFNMAP memory failure registration functions ankita
2025-12-13 4:47 ` [PATCH v2 3/3] vfio/nvgrace-gpu: register device memory for poison handling ankita
2025-12-13 8:00 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SA1PR12MB7199065CD785B5FD0BFE6FB9B0ABA@SA1PR12MB7199.namprd12.prod.outlook.com \
--to=ankita@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=alex@shazbot.org \
--cc=cjia@nvidia.com \
--cc=jgg@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=kevin.tian@intel.com \
--cc=kjaju@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mochs@nvidia.com \
--cc=nao.horiguchi@gmail.com \
--cc=skolothumtho@nvidia.com \
--cc=vsethi@nvidia.com \
--cc=yishaih@nvidia.com \
--cc=zhiw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox