From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE020D11195 for ; Wed, 26 Nov 2025 20:05:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C1536B0005; Wed, 26 Nov 2025 15:05:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 072426B000C; Wed, 26 Nov 2025 15:05:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E7B536B0029; Wed, 26 Nov 2025 15:05:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CFCFF6B0005 for ; Wed, 26 Nov 2025 15:05:50 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 82D05BB20E for ; Wed, 26 Nov 2025 20:05:50 +0000 (UTC) X-FDA: 84153838860.08.914D07A Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by imf14.hostedemail.com (Postfix) with ESMTP id 02F32100018 for ; Wed, 26 Nov 2025 20:05:45 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Te78isLi; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf14.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 192.198.163.12 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1764187546; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wo+rlc0JwB2D2BEysHHzVl7tLoYSlsFdR2YHJdEltfQ=; b=CyBBEHvsegZgU/iEw6CRYMmJOI/aP1YCkpVW+tEZzY+o+/dCzTxwafTRYV/5TJ0xwDPUhl /KT0TCtKKMRXZjUidXlQDwGQrP6RYar8xztFMNAIg24z3BfQ0E82YLDlV1p6dnDo6BF21a WXabMf+Z8Fyl3qO9mo60lMo8DMvCaBk= ARC-Authentication-Results: i=2; imf14.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Te78isLi; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf14.hostedemail.com: domain of kanchana.p.sridhar@intel.com designates 192.198.163.12 as permitted sender) smtp.mailfrom=kanchana.p.sridhar@intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1764187546; a=rsa-sha256; cv=pass; b=8etlu6jygVfGAS3a7bZ9Nebyf14qV3GyMQ1grVA1ClGgG9LWy+m+84PVqKF2ItL2FxXQOG LNyiJ3IsT3SGpOxTtqB51YUvVSDG0uNhgvKPU4DM42ExBgmZcGKSbWatt4gJth4yQnHKjH jF9U+zlLmSAWSo+tnQWLethEyfpmbRY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1764187546; x=1795723546; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=oNRNsU5J8wnsAngIJvswOlEVp4DB3bztbF3SSDVkoIk=; b=Te78isLij6FbvQQ9+2VL5R8ujx1SSwYEyhZvgJ44H9qMKsXdsot+tBwl 1LsnKrEws+l3W7I+uAdHmdmaMjMtiSzg7SRykkxvtVMau5BYts5JcAVaa 09OcqSixo6E1KMr95VKt1j5P2C563J7bcQ0QbP2Fh7r7GncjCndnHyDIA 1hUTry9ZD1330qXaLcLbsN/MEzGU06RMkYZvR8fGyyWAJw3YaEv2/iQNy LQZ/AyTrzMRvs30YEdvyI0GA8EXGtV3yajtuCp/Xxd6qtnt29rNT+xZi/ GCqZ3BH/CnbvCUGYckjKGhIXrc/V0YIh+mdf/FWT/hRkd5qitPyVhY8aa w==; X-CSE-ConnectionGUID: m+c/0xLnQ8GQFmbk+wCr0g== X-CSE-MsgGUID: vtnaDg7nT2aFv7p0O+EqTA== X-IronPort-AV: E=McAfee;i="6800,10657,11625"; a="70095531" X-IronPort-AV: E=Sophos;i="6.20,229,1758610800"; d="scan'208";a="70095531" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2025 12:05:44 -0800 X-CSE-ConnectionGUID: 4oKXDtexTsCGf1SumLnWMQ== X-CSE-MsgGUID: 6IkvMB6gQ5+iG0PVvSjZaA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.20,229,1758610800"; d="scan'208";a="198148668" Received: from fmsmsx903.amr.corp.intel.com ([10.18.126.92]) by orviesa005.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2025 12:05:44 -0800 Received: from FMSMSX901.amr.corp.intel.com (10.18.126.90) by fmsmsx903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Wed, 26 Nov 2025 12:05:43 -0800 Received: from fmsedg901.ED.cps.intel.com (10.1.192.143) by FMSMSX901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29 via Frontend Transport; Wed, 26 Nov 2025 12:05:43 -0800 Received: from SN4PR0501CU005.outbound.protection.outlook.com (40.93.194.60) by edgegateway.intel.com (192.55.55.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Wed, 26 Nov 2025 12:05:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=b5tIPn+F8woL6yB0zZNoRyWo6BZegRwL10GaIXXEV4+L8F3XseIkgCrRAkbrZuUJBtAdwgwugzQUQF2TrAurjEWtmFkNdNI6U0XFSaE9S1UJVO3eg28PMc5mEwmY/+ny6CHtP9iSOpyuW6Tjnji1Z7Pypq9whL36YcDNjM+Fuf8xvb4JvZcAYDajSN8PdOPpOzbpwg5kXI5gBCP0Rnls4ImNj3Wgjug6cb4QbvsqJtR2joGIQqECn6RfnWq8d3DpIjWfq8Vm6gkUW6ta24wx90uIPMDeWPdxP9C9SmKLNBp6pTVJDD1i6JPZgG2zA77d+qgBuom0Hxq473n2fdduGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wo+rlc0JwB2D2BEysHHzVl7tLoYSlsFdR2YHJdEltfQ=; b=xja8suTrbSunsBLBfowfV3L9Tcx23PZPfNVFwKQDjs/7fiJvK/GnDfQ+YHZDq3warpQBTCA+fIXoeMTiWuqDneJZRYmN0JzyjQbBu5ylARg8pXpbnrqeLZdS1jABA65lrFsdqoHpg19OwHLexLS8XuTh1Z7Iuz6uZ37fYwK56NZHlQMvm+8f8Zc/Kdiiq79dRlAvbzAj5ap8vW6BugvJJGyVPUJ6UQfVzLwzs274SNd3P9+kH+uoYBNPUP6TtfdrakgbBE0R6cc8TYThAW7Rw27SXuIuU7+a0bgzrfOruKNhNrNnaPtfnDd66Tuo5pPR/yAsyUnNa/dfOh6EE9+Utg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SA1PR11MB8476.namprd11.prod.outlook.com (2603:10b6:806:3af::20) by LV8PR11MB8560.namprd11.prod.outlook.com (2603:10b6:408:1e7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9343.10; Wed, 26 Nov 2025 20:05:40 +0000 Received: from SA1PR11MB8476.namprd11.prod.outlook.com ([fe80::4255:20e7:3c8d:300e]) by SA1PR11MB8476.namprd11.prod.outlook.com ([fe80::4255:20e7:3c8d:300e%4]) with mapi id 15.20.9366.012; Wed, 26 Nov 2025 20:05:40 +0000 From: "Sridhar, Kanchana P" To: Yosry Ahmed , Herbert Xu CC: SeongJae Park , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "hannes@cmpxchg.org" , "nphamcs@gmail.com" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "ryan.roberts@arm.com" , "21cnbao@gmail.com" <21cnbao@gmail.com>, "ying.huang@linux.alibaba.com" , "akpm@linux-foundation.org" , "senozhatsky@chromium.org" , "kasong@tencent.com" , "linux-crypto@vger.kernel.org" , "davem@davemloft.net" , "clabbe@baylibre.com" , "ardb@kernel.org" , "ebiggers@google.com" , "surenb@google.com" , "Accardi, Kristen C" , "Gomes, Vinicius" , "Feghali, Wajdi K" , "Gopal, Vinodh" , "Sridhar, Kanchana P" Subject: RE: [PATCH v13 22/22] mm: zswap: Batched zswap_compress() with compress batching of large folios. Thread-Topic: [PATCH v13 22/22] mm: zswap: Batched zswap_compress() with compress batching of large folios. Thread-Index: AQHcTWs0Qo3eNl0w/UamTXF2PMbCz7TxL9wAgAAcuzCAAG5HAIAABzqAgACcWYCAEjbfgIAADVuAgADeg0A= Date: Wed, 26 Nov 2025 20:05:40 +0000 Message-ID: References: <20251104091235.8793-1-kanchana.p.sridhar@intel.com> <20251104091235.8793-23-kanchana.p.sridhar@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR11MB8476:EE_|LV8PR11MB8560:EE_ x-ms-office365-filtering-correlation-id: cc204d31-161c-4a78-e007-08de2d272c52 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|366016|38070700021; x-microsoft-antispam-message-info: =?us-ascii?Q?IRKf+ZRhRNfl0yjI7gU2SBkWf2XzJLo9U/kg3JpKd1ypjCrX1Ot6jEt/S0sW?= =?us-ascii?Q?WiUqLw/ilU0/wFtexbxlhHrUPup69zmWdPc0wtsFe1qM3+SliW0NrKu3d8CF?= =?us-ascii?Q?HNF5l4F4HBAxTxSwreglJITAJnjQfNQVOY6fXSm//TJAWc/zO4lfCP08dHbo?= =?us-ascii?Q?j0M+lGf4g0lThTeZyBcL4K+wCUtX/Y2xFgoqk8xX32/bE37+RLA7sj3X0ZfW?= =?us-ascii?Q?hAeIB4hSEr5nvxOhwax9yWs6pCKbYjIbeYSo2KaVIrgSLAC757WMEmB1VoKL?= =?us-ascii?Q?wEDz12DR2Qn/aUyP52Y2QzFNG4eQZMi4Y3HQy57k06LGKd8R3+RCk1/jYHYQ?= =?us-ascii?Q?rIi9rj0xWblX7XgeHiPjwCI/sV0ZwkClIj9DWZmWmwNIu/PBDBwW4EhYmSLT?= =?us-ascii?Q?+E6DlFSozP2Wr+yfn8RmPJj3QnKtR1Ew6bqH8j0Sq6fzXBVxGhzK0jnrktPh?= =?us-ascii?Q?mP21VoItR4tE7Mfh5lOrNJY0igTq6n2XIOe1ckb3OZKgM4NDNb1SHW96O4AE?= =?us-ascii?Q?josbI4epWvVpoFalybBnMcsWK3QPv6fhkp7sSx4lSR+GSaTf3vux6hNoL+Jz?= =?us-ascii?Q?ZIeIKXPJyMmSp7WsV+/XSiK+0SphNc+pDxuzwBZb+Ez6FWcMCwZ5jmJxTWZf?= =?us-ascii?Q?EdKx+yDk0pXej5901OWYX5oWySuwGRqN6xoNBuPtgE6Vn6DCxjdgZaii9lBr?= =?us-ascii?Q?11ZVcU8RuZLWwFNUnGDmgfYZkrJ46xVZkykpUbvFGEvV0kLM+JPQkTdiKVg+?= =?us-ascii?Q?3ca9ftl5a+UVEIFpNygY19Eey5D7wCuF2D6hOy9Gd2Qc7NRA/5Hu+5jdqzXb?= =?us-ascii?Q?7aZiOYlhUOlbT5R+4JeSvsR+B5389Zsf2NaebZxaIz08Are98wk3A4fWRMTT?= =?us-ascii?Q?5pWd9nJd8zArwIcWdObycc8Gigt1jM2J5U2ydzUE1RdgbcXRF+gXo+rrEf44?= =?us-ascii?Q?+o6+D071cHwQcNuWqQfmwEqmzq28EOpAf29cm5neyHaULH/LPDb+OYdgLQAa?= =?us-ascii?Q?TaXpKfmmA2h18dxg6gf24RLqK4T3QG58Wy+G6Ng+KRE5/gmpAiwDV+Vppbhe?= =?us-ascii?Q?y/NxJ9EhUfXlY2RdM5e1BgCKFVsfBCuCUsLtZDYZsAP3Hlv5jQ5ExVi6Qejr?= =?us-ascii?Q?DglBJVNnw3HKXkaoz0SnyPEbirqXcDtPy3gnkE3KkEJEYLcQq9chyIrTjpMh?= =?us-ascii?Q?EfO58jsthYLns59RcU63mZBpX0iekv148p1QPgngH6aH5ridFiEPP6HeyzO5?= =?us-ascii?Q?PblRMl4P1rjO13ak70VkGDYs1D5OWlKeEgSydRzvpWit1hP6/sUsxtsgExWf?= =?us-ascii?Q?klMMRA3q45epi9Z1tEXY+SnEBryoIWsqIMionNRboc26aPW097UFMv334KRr?= =?us-ascii?Q?j637gQWpXnJdoIcrqT7fhq9VDqFde26KUcNLE8JMvOqb4PTensONmyqF664e?= =?us-ascii?Q?iVMUaRz8Is1AKrp77xdq8UScOOSc0VqW5wRsSOwxZjMUN+vGeoLGng=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA1PR11MB8476.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(366016)(38070700021);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?iWhP9B9pThlGre3hkVRBfIEsHQESZUzKmYkqMjewI1/hGloeY5v5qeZ3KJ28?= =?us-ascii?Q?aJ07l3bEW7cYD9xewEqZa1SUayDG0ZJiC1WOx0ntJb/D7ZoGuoZJ5Ef+ZIQb?= =?us-ascii?Q?+pbGkLjZUUxeBf5iGBbICUyYiGWPaJYnY/5cUNui0FxAW58SurTB3Scq+BsL?= =?us-ascii?Q?AXciieuTc5y5QxfgC3vmi5KQpr0vvOhuzKfy1QSA1p3kcAlr4s5T3hL6VgRA?= =?us-ascii?Q?LsnnDwklJ85oSGwJiFWfPxTM2ejKan2wE8NJiVk5PUNmLCMo8VGfCE3T5wQ5?= =?us-ascii?Q?NunOgkYwWITtMmgx89vBiKqBgKN1BYESLe/04CxemavoX1oQSUMN5tRetQFX?= =?us-ascii?Q?LgjgVQtLXDYCvMglBMIivw4dqaNW1e2PfazX+rlyYJX4bvZfRLjub02AD6T0?= =?us-ascii?Q?BPY/eyOtzUQzN8kGi9e25EwPtYm3Xa4dEKhiSAH8m/4NfidKl8iP3UXF2K8l?= =?us-ascii?Q?WK2OTKjEyMgUS8q/qxLoh3p43BLHcYRMbMZ6RqJYWjE63erXf5fxKvsGa+y2?= =?us-ascii?Q?pTLTZNCKrOsaKwaLfBGeXpPrg6NlqCraN4X8ZIPlVzRDjYMwYhRC3KfpiVFk?= =?us-ascii?Q?z7EkWRW3Kuhqo3Y8FuGY34AaxCxgjE5I0l+uko8YCcCbc1YOWEeKOekgJdXV?= =?us-ascii?Q?F18/xW4V/lp7KDBKz8Hyq2Posc9FN8Egcad730i5auSATEMU4LCAFNp3xi9p?= =?us-ascii?Q?0pPI/xlNiGBEN9JCCb53mVBU3XeOj9rTkMlDXGZJMJQZifDfXlcmIfWnKpA3?= =?us-ascii?Q?FfeXHdpKJ9oK4CA6ggwXia/jXxSdHegzYpEY/LzMV7C5de4ONSIgr8xwfM5i?= =?us-ascii?Q?oN8K6UG0J6VGSAo6o0xdMK9gu1rI//DN4k2y99w50gUp5+4TYYoHR58qlGt/?= =?us-ascii?Q?OAuHmYeRAFZc56h3F6w+E8l1rEQ2K90+V38ebN/GVKy0/i5CJIe7ScHGNK02?= =?us-ascii?Q?L45HZltqiNejY2VlBxX8uLkpFNolsZBA6UjUcJmqD0mO+16lf4Irh+IcSxAY?= =?us-ascii?Q?8NHPabbV6h84M7SheH3nvNaehDk/lRkiyVVtZa80y9ewdF4ISGYGKEUyqin6?= =?us-ascii?Q?j/xb3puz4kxK7xzzaMed/noNZLoMG6470dIn3g0ce5vXJhR16Tzat8ptDlFq?= =?us-ascii?Q?h2nMNNma1mJegogAy3P914Qc+m84e52JTSpZ4627x8EyypbKcgby2ndm1+y5?= =?us-ascii?Q?3BWNrMHEDXV7fN69Ab/uVUSpxPp525R9H1pZC3fFEsTUzOH4IgYN1vsLvqq/?= =?us-ascii?Q?+xrec1Qjn+bJmCk3slP78VZYYPwoO94qJpxTUtOXc+zpWoCY+MUMXdUlqxEk?= =?us-ascii?Q?Nfi0sY4iyZTvbfStkE4iKsS3u80Hsxrg4B9LcRCcaBh+/8b8qclA5H1xwOP0?= =?us-ascii?Q?/VkPAOemQORtJXbCeTFCVvLJG5ibkTgPNDgVquOO1IuiJpC8Rbm5xHHbVM8E?= =?us-ascii?Q?0Z3wUUNssBoQZe5owwR6ZLUamJdelYV21A4bQRT4Zm/ui7U5zajWFB3g8qJ1?= =?us-ascii?Q?rPZXoVLgUTv7nocMKBn2Ses37L7QfC/GaIdddDvjtD2GZHbfJDA6jLPl0+sh?= =?us-ascii?Q?KPPH9q4UWQ1YHE/6kMRApViRBnTdqHFcUWBoXvE7RTWnLqZ+IrV8U7i0jXPw?= =?us-ascii?Q?fg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB8476.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc204d31-161c-4a78-e007-08de2d272c52 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Nov 2025 20:05:40.3422 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TRniULh2hwHdkUGnUIfhZDIi24ZK70IR994JOaptU3RbqFeoYVrpeCkx0irWmmMncsvLsn0zN/PM5nItETKOxDV9nnGxE04wIDSzebIQwoM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8560 X-OriginatorOrg: intel.com X-Rspam-User: X-Rspamd-Queue-Id: 02F32100018 X-Rspamd-Server: rspam11 X-Stat-Signature: n938sda8t7117tpxt3go6jwyucax96zt X-HE-Tag: 1764187545-583337 X-HE-Meta: U2FsdGVkX1/zAVBD3Wrq66/nuRftPmipWerUvyAG8kaLEFjfCLpS0mLHlW5utkDexKrcgds/frRrlnDAeYC6ktdVHgkR8x+vRvomBUbJDBxmHGtAVzRtzT4icctpiCsoM3S3WWgtI59x/LnYge4p8DqU7VsvzG2/xesDocy07Vmhgs+cmgZc+b++8FdXVy2Bxy2F63peNZsC9CdE52o5L9B1LNH0gh4djf4zQbnwBag5UEZzDffWNdq1y6IZflh2i50/AEizpF6f0y4VcpRc69gSdAyrNyTVtH1HIVqV5oWICSjsNYtuXHrkgu/kk1sflB2rs1N6FBUDsyCTTrnDEdW/jkZrzAs9o+g6eQubeSc49OlHvFadQ5NzdUVX8c8I/X567AqXt1tRCscCNzvIcCF9LgluZuV7ipa4S70XW4kBwsB1zMWJ7CF6MeEPtVEByuS1HmAmPWmemnbTNafug99UsOb4kfJAgec8/j0ohjsSovRHCoj0bF/DEu2vDalensRpdhsLuluoBF7bt2ZxA9DWzNwlWtCD1+WOnfIc8xG4wYqI8/wAIqO12SFTIaqcAu5iBXf/KG/BSD971EivOAu9Mq9tDBbH8BUhGlvsey4k4EPW8VIGAl7nK2xsgw1JSX1weHvZeZKhfXsZduKQeBHssUw1Yeyz1w91DIHvdeQI6i1EqopIZwJJMzBt/qtLehA1gM2z5pFzjd7U/CP1OmgIgbLsQY2zYvsSE5jUNOQauqp6MEliRRbagx6XpnspXdSt10ixZrl5AdLpu8wmdksj2UayrbHUPmfSEPZJwlJ9DSea8nk0kp8ZbWsQ69W3Uih84G60ZmGgg1hT5BcDtypUeGbExPkts8CVxLDZOVqohPeHgrf1AddmHoavBMFtWPrupvEeJ/ITAnTGHywgM+X0oTS564MeuBsyL6idM8SOGFSU0fVwTDfyUbgHH5NG/oZBl5KVqlcPVdESlMX pdENJomg cdBxh8TRkcCRUS+xUEIaJckklTdkwPisKNaQjzVE+bUMc5gGITUxKIQTvwYVoa8zaIBrqHoZn53o5k0iQSA+ckCHOPZY9hwo0rr7M6lLXaDQ76dgKkx0v3rv/+tKERLJakj0rr96caMzgu6LMaRlQabs+t8VdvGNNe/sMJj2qNcHpnc6zEfS1LkW7WCI57CrJcpC59Z143zbVl+NSQ7sgni90axBQByn57x+KJWSzcCjpgNP5Y7T4A//iSAqjNMqZUmMRcPetEcE33z8MWm8DlnglvylKr/UD9W8Dw5iJVW+aeUWey7BfeSQnNFIqwUXiEJUNVrGPqovMM2z7X3C1MOsVRR/2OTf1YznvKRU8t5kFMjt8EvrDvxcUlU4lOJ0VdPkw7bUNkoKJ48FwRzWHUaRwcNK4IjFh7yKCKyIKJYtC47C2mrextCayE+NBBVpxvfYWvZR3MDI0+UrRw7g2JfgCl084lzXstPbfoMV8Ed4QAkm6ZUzs2+CxDD0Cp5aAxxS8F7CLb3qMVPeEWMk8Vo7pfL1tuUWUhuTrWeRlHdQHcS44I0lEvfr8fHUjufBHvLizvjlJcBla6e2YDjgJ9FF/prKjyO2iUqRskTH4drb5iTLDRXeH1EYXlI40nvR7MvUgEv16wnKtyq9fNhva+ugqvrivLfAGVGlnX2DAF3kGqrBc9KSgVyOu5SQeyX+edR/1pYznat8O9Kt8dTNZxFJbKwB7tqfl/TlUGO5XqYSOfqvV4kGx6DphAlCAFONVmnzrsjyuSVJ5cEATijlK1uyhd4ta93lH5JqviA8D+paC/NPtgkmVOWVWjCa2TF99lIr0LedE1M2gANT9YwpcMv8ndbumPWTfzPY4odKpwA8TbZ35QhIpHMbSt7GCJS3H75B2cBkHpWKZJ1xh65n9QN6xvXfu7da1857n1dgJsX5fYrwY54p3QIFqAdoVuTLKEdaajZ984sgLrjjjeXWCJv5uNg0l 9SHLs01W yB+wKPDL9ZtrKHLsb86vCVwOiH02xA87UgeOupV+bBkYrAkjkamfbzTVXwKL834jSjcyUxsvkj6OK/DPhWyPZRaFel4ojF2qmieAShabfK1Z9FFsSGsBEFvzlLEl4orgWQmIoICpRAA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > -----Original Message----- > From: Yosry Ahmed > Sent: Tuesday, November 25, 2025 10:35 PM > To: Herbert Xu > Cc: Sridhar, Kanchana P ; SeongJae Park > ; linux-kernel@vger.kernel.org; linux-mm@kvack.org; > hannes@cmpxchg.org; nphamcs@gmail.com; chengming.zhou@linux.dev; > usamaarif642@gmail.com; ryan.roberts@arm.com; 21cnbao@gmail.com; > ying.huang@linux.alibaba.com; akpm@linux-foundation.org; > senozhatsky@chromium.org; kasong@tencent.com; linux- > crypto@vger.kernel.org; davem@davemloft.net; clabbe@baylibre.com; > ardb@kernel.org; ebiggers@google.com; surenb@google.com; Accardi, > Kristen C ; Gomes, Vinicius > ; Feghali, Wajdi K ; > Gopal, Vinodh > Subject: Re: [PATCH v13 22/22] mm: zswap: Batched zswap_compress() with > compress batching of large folios. >=20 > On Wed, Nov 26, 2025 at 01:46:57PM +0800, Herbert Xu wrote: > > On Fri, Nov 14, 2025 at 03:37:53PM +0000, Yosry Ahmed wrote: > > > > > > Thanks for the clarification. I understand that the error code has > > > different sources for SW and HW compressors, but I do not like using > > > errp as an indirection. It makes the code unclear. I would rather we > > > explicitly check err for SW compressors and dlen for HW compressors. > > > > > > That being said, I thought what Herbert suggested was that the same A= PI > > > is used for both SW and HW compressors. IOW, either way we submit a > > > batch of pages (8 pages for SW compressors), and then the crypto API > > > would either give the entire batch to the compressor if it supports > > > batching, or loop over them internally and hand them page-by-page to > > > the compressor. > > > > > > This would simplify usage as we do not have to handle the differences= in > > > zswap. > > > > > > If that is not doable, at the very least the API should be consistent= . > > > Right now the error code and length are propagated differently to the > > > caller based on whether or not the compressor support batching. > > > > Yes we should only have one code path in zswap, regardless of whether > > batching is used or not. > > > > The degenerate case of a batch with a single page should be handled > > by the Crypto API. > > > > So I will change crypto_acomp to take care of this case. >=20 > Nice :) Thanks Herbert and Yosry! Herbert, to make sure I understand, will you be implementing all of these features in crypto_acomp for software compressors? I would appreciate it if you can clarify: 1) Error & compressed length propagation to the dst sg->length only for non-batching compressors. a) For batching compressors, this wouldn't apply since errors could occ= ur for any page in the batch, and the first page (dst sg->length) coul= d have successfully compressed. 2) Will you also be handling the case where zswap can send an SG list batch with multiple pages to a non-batching compressor, and the crypto_acomp API will internally compress each page sequentially, propagate errors/compress lengths before returning? =20 If so, this would really standardize the code in zswap for batching and non-batching compressors. Thanks, Kanchana >=20 > > > > Cheers, > > -- > > Email: Herbert Xu > > Home Page: http://gondor.apana.org.au/~herbert/ > > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt