From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 15 Jul 2004 16:52:37 -0500 From: Brent Casavant Reply-To: Brent Casavant Subject: Re: [PATCH] /dev/zero page fault scaling In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Hugh Dickins Cc: linux-mm@kvack.org List-ID: On Thu, 15 Jul 2004, Hugh Dickins wrote: > + /* Keep it simple: disallow limited <-> unlimited remount */ > + if ((max_blocks || max_inodes) == !sbinfo) > + return -EINVAL; Just caught this one. Shouldn't this be: if ((max_blocks || max_inodes) && !sbinfo) return -EINVAL; Otherwise I think it looks good, though I don't understand some parts of it of course. I'm pretty sure it solves the SysV shared memory scaling problem as well, just by visual inspection. I'll give the patch a whirl when I can next schedule time on our 512P. Thanks, Brent -- Brent Casavant bcasavan@sgi.com Forget bright-eyed and Operating System Engineer http://www.sgi.com/ bushy-tailed; I'm red- Silicon Graphics, Inc. 44.8562N 93.1355W 860F eyed and bushy-haired. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org