From: Brent Casavant <bcasavan@sgi.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH] /dev/zero page fault scaling
Date: Thu, 15 Jul 2004 16:52:37 -0500 [thread overview]
Message-ID: <Pine.SGI.4.58.0407151647100.116400@kzerza.americas.sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0407152038160.8010-100000@localhost.localdomain>
On Thu, 15 Jul 2004, Hugh Dickins wrote:
> + /* Keep it simple: disallow limited <-> unlimited remount */
> + if ((max_blocks || max_inodes) == !sbinfo)
> + return -EINVAL;
Just caught this one.
Shouldn't this be:
if ((max_blocks || max_inodes) && !sbinfo)
return -EINVAL;
Otherwise I think it looks good, though I don't understand some parts
of it of course. I'm pretty sure it solves the SysV shared memory
scaling problem as well, just by visual inspection.
I'll give the patch a whirl when I can next schedule time on our 512P.
Thanks,
Brent
--
Brent Casavant bcasavan@sgi.com Forget bright-eyed and
Operating System Engineer http://www.sgi.com/ bushy-tailed; I'm red-
Silicon Graphics, Inc. 44.8562N 93.1355W 860F eyed and bushy-haired.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-07-15 21:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-14 19:27 Brent Casavant
2004-07-14 20:39 ` Hugh Dickins
2004-07-14 21:31 ` Brent Casavant
2004-07-15 16:28 ` Brent Casavant
2004-07-15 20:28 ` Hugh Dickins
2004-07-15 21:36 ` Brent Casavant
2004-07-15 21:52 ` Brent Casavant [this message]
2004-07-15 23:21 ` Hugh Dickins
2004-07-16 22:35 ` Brent Casavant
2004-08-02 14:37 ` Brent Casavant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.SGI.4.58.0407151647100.116400@kzerza.americas.sgi.com \
--to=bcasavan@sgi.com \
--cc=hugh@veritas.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox