From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx129.postini.com [74.125.245.129]) by kanga.kvack.org (Postfix) with SMTP id 0E1696B0082 for ; Thu, 16 Feb 2012 14:13:58 -0500 (EST) Date: Thu, 16 Feb 2012 11:13:53 -0800 (PST) From: Sage Weil Subject: Re: [PATCH 04/11] ceph: Push file_update_time() into ceph_page_mkwrite() In-Reply-To: <1329419077.3121.38.camel@doink> Message-ID: References: <1329399979-3647-1-git-send-email-jack@suse.cz> <1329399979-3647-5-git-send-email-jack@suse.cz> <1329419077.3121.38.camel@doink> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Alex Elder Cc: Jan Kara , LKML , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Eric Sandeen , Dave Chinner , ceph-devel@vger.kernel.org On Thu, 16 Feb 2012, Alex Elder wrote: > On Thu, 2012-02-16 at 14:46 +0100, Jan Kara wrote: > > CC: Sage Weil > > CC: ceph-devel@vger.kernel.org > > Signed-off-by: Jan Kara > > > This will update the timestamp even if a write > fault fails, which is different from before. > > Hard to avoid though. > > Looks good to me. Yeah. Let's put something in the tracker to take a look later (I think we can do better), but this is okay for now. Signed-off-by: Sage Weil > > Signed-off-by: Alex Elder > > > fs/ceph/addr.c | 3 +++ > > 1 files changed, 3 insertions(+), 0 deletions(-) > > > > diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c > > index 173b1d2..12b139f 100644 > > --- a/fs/ceph/addr.c > > +++ b/fs/ceph/addr.c > > @@ -1181,6 +1181,9 @@ static int ceph_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf) > > loff_t size, len; > > int ret; > > > > + /* Update time before taking page lock */ > > + file_update_time(vma->vm_file); > > + > > size = i_size_read(inode); > > if (off + PAGE_CACHE_SIZE <= size) > > len = PAGE_CACHE_SIZE; > > > > -- > To unsubscribe from this list: send the line "unsubscribe ceph-devel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org