From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with SMTP id 6923B6B006A for ; Wed, 18 Nov 2009 11:33:05 -0500 (EST) Date: Wed, 18 Nov 2009 16:32:43 +0000 (GMT) From: Hugh Dickins Subject: Re: [PATCH 2/6] mm: mlocking in try_to_unmap_one In-Reply-To: <20091117103620.3DC4.A69D9226@jp.fujitsu.com> Message-ID: References: <20091113143930.33BF.A69D9226@jp.fujitsu.com> <20091117103620.3DC4.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: KOSAKI Motohiro Cc: Andrew Morton , Izik Eidus , Andrea Arcangeli , Nick Piggin , Rik van Riel , Lee Schermerhorn , linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: On Tue, 17 Nov 2009, KOSAKI Motohiro wrote: > > From 7332f765dbaa1fbfe48cf8d53b20048f7f8105e0 Mon Sep 17 00:00:00 2001 > From: KOSAKI Motohiro > Date: Tue, 17 Nov 2009 10:46:51 +0900 > Subject: comment adding to mlocking in try_to_unmap_one > > Current code doesn't tell us why we don't bother to nonlinear kindly. > This patch added small adding explanation. > > Signed-off-by: KOSAKI Motohiro Acked-by: Hugh Dickins (if the "MLOCK_PAGES && " is removed from this one too) > --- > mm/rmap.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/mm/rmap.c b/mm/rmap.c > index 81a168c..c631407 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -1061,7 +1061,11 @@ static int try_to_unmap_file(struct page *page, enum ttu_flags flags) > if (list_empty(&mapping->i_mmap_nonlinear)) > goto out; > > - /* We don't bother to try to find the munlocked page in nonlinears */ > + /* > + * We don't bother to try to find the munlocked page in nonlinears. > + * It's costly. Instead, later, page reclaim logic may call > + * try_to_unmap(TTU_MUNLOCK) and recover PG_mlocked lazily. > + */ > if (MLOCK_PAGES && TTU_ACTION(flags) == TTU_MUNLOCK) > goto out; > > -- > 1.6.2.5 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org