From: Hugh Dickins <hugh.dickins@tiscali.co.uk>
To: Huang Shijie <shijie8@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org
Subject: Re: [PATCH] filemap : fix the wrong offset
Date: Thu, 1 Oct 2009 11:24:58 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0910011111590.7682@sister.anvils> (raw)
In-Reply-To: <4AC2CF46.5070600@gmail.com>
On Wed, 30 Sep 2009, Huang Shijie wrote:
>
> But the filemap_fault() looks strange. Some functions such as
> do_sync_mmap_readahead() treat offset
> in the PAGE_CAHE_SHIFT unit,though offset is actually in the PAGE_SHIFT unit.
If this one stands out to you as a puzzling place where it's important
to acknowledge the possibility of the difference, please don't take what
I said too seriously: go ahead and send Andrew the patch again, perhaps
adding a comment that this wouldn't be the only place that's wrong.
Or do you think this is the only place? I'd be surprised, but
haven't checked: perhaps we have cleaned others up down the years.
I just don't want a long trickle of such patches here and there.
And there's not a lot of point in getting everywhere fixed up,
because people are sure to add patches later which get it wrong again.
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2009-10-01 9:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-29 9:06 Huang Shijie
2009-09-29 11:02 ` Hugh Dickins
2009-09-30 3:23 ` Huang Shijie
2009-10-01 10:24 ` Hugh Dickins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0910011111590.7682@sister.anvils \
--to=hugh.dickins@tiscali.co.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=shijie8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox