From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with SMTP id C35166B005A for ; Tue, 29 Sep 2009 06:06:51 -0400 (EDT) Date: Tue, 29 Sep 2009 11:28:36 +0100 (BST) From: Hugh Dickins Subject: Re: [PATCH] rmap : tidy the code In-Reply-To: <4AC16B8F.1060308@gmail.com> Message-ID: References: <1254128590-27826-1-git-send-email-shijie8@gmail.com> <8acda98c0909280430w2700826cu55f9629bafab066f@mail.gmail.com> <4AC16B8F.1060308@gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: Huang Shijie Cc: Nikita Danilov , akpm@linux-foundation.org, linux-mm@kvack.org List-ID: On Tue, 29 Sep 2009, Huang Shijie wrote: > Nikita Danilov wrote: > > I agree that adding EFAULT check into page_check_address() is better. > > The only call-site that does not call vma_address() before > > page_check_address() is __xip_unmap() and it explicitly BUG_ON()s on > > the same condition. > > > > > If adding vma_address() into page_check_address() , it's bad for > __xip_unmap to change its code. > __xip_unmap must fake a page to satisfy the new "page_check_address()". You're right, I'd missed that too. Hugh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org