From: Hugh Dickins <hugh.dickins@tiscali.co.uk>
To: Huang Shijie <shijie8@gmail.com>
Cc: Nikita Danilov <danilov@gmail.com>,
akpm@linux-foundation.org, linux-mm@kvack.org
Subject: Re: [PATCH] rmap : tidy the code
Date: Tue, 29 Sep 2009 11:28:36 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0909291127480.19216@sister.anvils> (raw)
In-Reply-To: <4AC16B8F.1060308@gmail.com>
On Tue, 29 Sep 2009, Huang Shijie wrote:
> Nikita Danilov wrote:
> > I agree that adding EFAULT check into page_check_address() is better.
> > The only call-site that does not call vma_address() before
> > page_check_address() is __xip_unmap() and it explicitly BUG_ON()s on
> > the same condition.
> >
> >
> If adding vma_address() into page_check_address() , it's bad for
> __xip_unmap to change its code.
> __xip_unmap must fake a page to satisfy the new "page_check_address()".
You're right, I'd missed that too.
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2009-09-29 10:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-28 9:03 Huang Shijie
2009-09-28 10:44 ` Hugh Dickins
2009-09-28 11:30 ` Nikita Danilov
2009-09-29 2:06 ` Huang Shijie
2009-09-29 10:28 ` Hugh Dickins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0909291127480.19216@sister.anvils \
--to=hugh.dickins@tiscali.co.uk \
--cc=akpm@linux-foundation.org \
--cc=danilov@gmail.com \
--cc=linux-mm@kvack.org \
--cc=shijie8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox