From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with SMTP id 85BA06B00AD for ; Fri, 18 Sep 2009 04:00:33 -0400 (EDT) Date: Fri, 18 Sep 2009 08:59:40 +0100 (BST) From: Hugh Dickins Subject: Re: [PATCH 2/4] send callback when swap slot is freed In-Reply-To: <1253260528.4959.13.camel@penberg-laptop> Message-ID: References: <1253227412-24342-1-git-send-email-ngupta@vflare.org> <1253227412-24342-3-git-send-email-ngupta@vflare.org> <1253256805.4959.8.camel@penberg-laptop> <1253260528.4959.13.camel@penberg-laptop> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: Pekka Enberg Cc: Nitin Gupta , Greg KH , Andrew Morton , Ed Tomlinson , linux-kernel , linux-mm , linux-mm-cc , kamezawa.hiroyu@jp.fujitsu.com, nishimura@mxp.nes.nec.co.jp List-ID: On Fri, 18 Sep 2009, Pekka Enberg wrote: > > The *hook* looks OK to me but set_swap_free_notify() looks like an ugly > hack. I don't understand why we're setting up the hook lazily in > ramzswap_read() nor do I understand why we need to look up struct > swap_info_struct with a bdev. Surely there's a cleaner way to do all > this? Probably somewhere in sys_swapon()? Sounds like you have something in mind, may well be better, but please show us a patch... (my mind is elsewhere!) Hugh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org