From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with SMTP id 49E5E6B004F for ; Mon, 8 Jun 2009 14:10:27 -0400 (EDT) Date: Mon, 8 Jun 2009 19:01:20 +0100 (BST) From: Hugh Dickins Subject: Re: [PATCH mmotm] ksm: stop scan skipping pages In-Reply-To: <4A2D4D9F.8080103@redhat.com> Message-ID: References: <1242261048-4487-1-git-send-email-ieidus@redhat.com> <4A2D4D9F.8080103@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org To: Izik Eidus Cc: aarcange@redhat.com, akpm@linux-foundation.org, nickpiggin@yahoo.com.au, chrisw@redhat.com, riel@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: On Mon, 8 Jun 2009, Izik Eidus wrote: > > Thanks for the fix, > (I saw it while i wrote the RFC patch for the madvise, but beacuse that i > thought that the RFC fix this (you can see the removel of the second call to > scan_get_next_index()), and we move to madvise, I thought that no patch is > needed for this code, guess I was wrong) Ah, no, I hadn't noticed that, this patch is from several weeks ago, before you even posted the madvise() version. I think myself that we ought to fix the algorithm as it stands now in mmotm, rather than hiding the fix in amongst later interface changes. But it's not a big deal, so long as it gets fixed in the end. By the time Andrew sends KVM to Linus, it shouldn't be the patches currently in mmotm with more on top: they should be re-presented with all trace of /dev/ksm gone by then. Hugh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org