From: Hugh Dickins <hugh@veritas.com>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Minchan Kim <minchan.kim@gmail.com>,
linux-mm <linux-mm@kvack.org>,
lkml <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux-foundation.org>,
Nick Piggin <npiggin@suse.de>
Subject: Re: add_to_swap_cache with GFP_ATOMIC ?
Date: Wed, 1 Apr 2009 12:46:13 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0904011245130.12751@blonde.anvils> (raw)
In-Reply-To: <20090401165516.B1EB.A69D9226@jp.fujitsu.com>
On Wed, 1 Apr 2009, KOSAKI Motohiro wrote:
>
> IOW, GFP_ATOMIC on add_to_swap() was introduced accidentally. the reason
> was old add_to_page_cache() didn't have gfp_mask parameter and we didn't
> have the reason of changing add_to_swap() behavior.
> I think it don't have deeply reason and changing GFP_NOIO
> don't cause regression.
You may well be right: we'll see if you send in a patch to change it.
But I won't be sending in that patch myself, that's all :)
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-04-01 11:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-31 10:38 Minchan Kim
2009-03-31 11:17 ` Hugh Dickins
2009-03-31 11:30 ` Minchan Kim
2009-04-01 8:38 ` KOSAKI Motohiro
2009-04-01 9:13 ` KOSAKI Motohiro
2009-04-01 11:46 ` Hugh Dickins [this message]
2009-04-01 13:30 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0904011245130.12751@blonde.anvils \
--to=hugh@veritas.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox