Re: [PATCH] use css id in swap cgroup for saving memory v5

[Hugh Dickins <hugh@veritas.com>]

Sorry, you'd prefer my input on the rest, which I've not studied, but ...

On Wed, 11 Mar 2009, KAMEZAWA Hiroyuki wrote:
...
>  
> @@ -432,7 +428,7 @@ int swap_cgroup_swapon(int type, unsigne
>  
>  	printk(KERN_INFO
>  		"swap_cgroup: uses %ld bytes of vmalloc for pointer array space"
> -		" and %ld bytes to hold mem_cgroup pointers on swap\n",
> +		" and %ld bytes to hold mem_cgroup information per swap ents\n",
>  		array_size, length * PAGE_SIZE);
>  	printk(KERN_INFO
>  	"swap_cgroup can be disabled by noswapaccount boot option.\n");

... I do get very irritated by all the screenspace these messages take
up every time I swapon.  I can see that you're following a page_cgroup
precedent, one which never bothered me because it got buried in dmesg;
and most other people wouldn't be doing swapon very often, and wouldn't
be logging to a visible screen ... but is there any chance of putting an
approximation to this info in the CGROUP_MEM_RES_CTRL_SWAP Kconfig help
text and removing these runtime messages?  How do other people feel?

I'm also disappointed that we invented such a tortuously generic boot
option as "cgroup_disable=memory", then departed from it when the very
first extension "noswapaccount" was required.  "cgroup_disable=swap"?
Probably too late.

Hugh

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>