From: Hugh Dickins <hugh@veritas.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: dwmw2@infradead.org, jens.axboe@oracle.com, matthew@wil.cx,
joern@logfs.org, James.Bottomley@HansenPartnership.com,
djshin90@gmail.com, teheo@suse.de, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/9] swapfile: change discard pgoff_t to sector_t
Date: Wed, 3 Dec 2008 12:52:53 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0812031251260.6817@blonde.anvils> (raw)
In-Reply-To: <20081202164732.1d6d0997.akpm@linux-foundation.org>
On Tue, 2 Dec 2008, Andrew Morton wrote:
> On Mon, 1 Dec 2008 00:29:41 +0000 (GMT)
> Hugh Dickins <hugh@veritas.com> wrote:
>
> > - pgoff_t nr_blocks = se->nr_pages << (PAGE_SHIFT - 9);
> > + sector_t nr_blocks = se->nr_pages << (PAGE_SHIFT - 9);
>
> but, but, that didn't change anything? se->nr_pages must be cast to
> sector_t?
I'm squirming, you are right, thanks for fixing it up.
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-12-03 12:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 21:35 [PATCH 0/9] swapfile: cleanups and solidstate mods Hugh Dickins
2008-11-25 21:36 ` [PATCH 1/9] swapfile: swapon needs larger size type Hugh Dickins
2008-11-25 21:37 ` [PATCH 2/9] swapfile: remove SWP_ACTIVE mask Hugh Dickins
2008-11-25 21:37 ` [PATCH 3/9] swapfile: remove surplus whitespace Hugh Dickins
2008-11-25 21:39 ` [PATCH 4/9] swapfile: remove v0 SWAP-SPACE message Hugh Dickins
2008-11-25 21:40 ` [PATCH 5/9] swapfile: rearrange scan and swap_info Hugh Dickins
2008-11-25 21:44 ` [PATCH 6/9] swapfile: swapon use discard (trim) Hugh Dickins
2008-11-25 21:46 ` [PATCH 7/9] swapfile: swap allocation use discard Hugh Dickins
2008-12-01 0:29 ` [PATCH 10/9] swapfile: change discard pgoff_t to sector_t Hugh Dickins
2008-12-03 0:47 ` Andrew Morton
2008-12-03 12:52 ` Hugh Dickins [this message]
2008-11-25 21:46 ` [PATCH 8/9] swapfile: swapon randomize if nonrot Hugh Dickins
2008-11-26 1:20 ` Andrew Morton
2008-11-26 3:38 ` Matthew Wilcox
2008-12-01 0:32 ` [PATCH 11/9] swapfile: let others seed random Hugh Dickins
2008-11-25 21:47 ` [PATCH 9/9] swapfile: swap allocation cycle if nonrot Hugh Dickins
2008-11-26 1:17 ` [PATCH 6/9] swapfile: swapon use discard (trim) Andrew Morton
2008-11-26 6:02 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0812031251260.6817@blonde.anvils \
--to=hugh@veritas.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=djshin90@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jens.axboe@oracle.com \
--cc=joern@logfs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew@wil.cx \
--cc=teheo@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox