From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 2 Dec 2008 07:12:01 -0600 (CST) From: Christoph Lameter Subject: Re: [PATCH 1/8] badpage: simplify page_alloc flag check+clear In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Hugh Dickins Cc: Andrew Morton , Russ Anderson , Nick Piggin , Dave Jones , Arjan van de Ven , Martin Schwidefsky , linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: On Tue, 2 Dec 2008, Hugh Dickins wrote: > > But they are always clear on free. The checking is irrelevant. > > How about CHECK_PAGE_FLAGS_CLEAR_AT_FREE? Strange name. > The one I really disliked was "PAGE_FLAGS" for an obscure > subset of page flags, and have got rid of that. Good. > > If (page->flags & (all the flags including dirty and SwapBacked)) > > zap-em. > > That's exactly what I did, isn't it? Yes but you added another instance of this. Can you consolidate all the check and clears into one? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org