linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Hugh Dickins <hugh@veritas.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>, linux-mm@kvack.org
Subject: [PATCH 0/9] swapfile: cleanups and solidstate mods
Date: Tue, 25 Nov 2008 21:35:02 +0000 (GMT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0811252132580.17555@blonde.site> (raw)

Here's a batch of 9 mm patches, intended for 2.6.29: a minor bugfix
and some cleanups in swapfile.c, before improving the behaviour of
swap on solidstate, by implementing discard and better nonrotational
allocation.  Hopefully.  I don't have a device which reports either
capability, so have merely hacked it for testing.

I'll send all the patches to linux-mm,
but add linux-kernel and a panel of experts in for the last four.

Though most of the testing has been against 2.6.28-rc6 and its
precursors, these patches are diffed to slot in to the mmotm series
after my previous patches, just before "mmend".

 include/linux/swap.h |   14 -
 mm/swapfile.c        |  449 +++++++++++++++++++++++++++++------------
 2 files changed, 330 insertions(+), 133 deletions(-)

The reindentation of sys_swapon() in 4/9 does clash with
memcg-swap-cgroup-for-remembering-usage.patch
Please replace its final hunk by these two hunks
(the second hunk fixes freeing of resources on error):

@@ -1821,6 +1825,11 @@ asmlinkage long sys_swapon(const char __
 		}
 		swap_map[page_nr] = SWAP_MAP_BAD;
 	}
+
+	error = swap_cgroup_swapon(type, maxpages);
+	if (error)
+		goto bad_swap;
+
 	nr_good_pages = swap_header->info.last_page -
 			swap_header->info.nr_badpages -
 			1 /* header page */;
@@ -1893,6 +1902,7 @@ bad_swap:
 		bd_release(bdev);
 	}
 	destroy_swap_extents(p);
+	swap_cgroup_swapoff(type);
 bad_swap_2:
 	spin_lock(&swap_lock);
 	p->swap_file = NULL;

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2008-11-25 21:35 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-25 21:35 Hugh Dickins [this message]
2008-11-25 21:36 ` [PATCH 1/9] swapfile: swapon needs larger size type Hugh Dickins
2008-11-25 21:37 ` [PATCH 2/9] swapfile: remove SWP_ACTIVE mask Hugh Dickins
2008-11-25 21:37 ` [PATCH 3/9] swapfile: remove surplus whitespace Hugh Dickins
2008-11-25 21:39 ` [PATCH 4/9] swapfile: remove v0 SWAP-SPACE message Hugh Dickins
2008-11-25 21:40 ` [PATCH 5/9] swapfile: rearrange scan and swap_info Hugh Dickins
2008-11-25 21:44 ` [PATCH 6/9] swapfile: swapon use discard (trim) Hugh Dickins
2008-11-25 21:46   ` [PATCH 7/9] swapfile: swap allocation use discard Hugh Dickins
2008-12-01  0:29     ` [PATCH 10/9] swapfile: change discard pgoff_t to sector_t Hugh Dickins
2008-12-03  0:47       ` Andrew Morton
2008-12-03 12:52         ` Hugh Dickins
2008-11-25 21:46   ` [PATCH 8/9] swapfile: swapon randomize if nonrot Hugh Dickins
2008-11-26  1:20     ` Andrew Morton
2008-11-26  3:38       ` Matthew Wilcox
2008-12-01  0:32     ` [PATCH 11/9] swapfile: let others seed random Hugh Dickins
2008-11-25 21:47   ` [PATCH 9/9] swapfile: swap allocation cycle if nonrot Hugh Dickins
2008-11-26  1:17   ` [PATCH 6/9] swapfile: swapon use discard (trim) Andrew Morton
2008-11-26  6:02     ` Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0811252132580.17555@blonde.site \
    --to=hugh@veritas.com \
    --cc=akpm@linux-foundation.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox