linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Pekka J Enberg <penberg@cs.helsinki.fi>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-mm@kvack.org, cl@linux-foundation.org, david@fromorbit.com,
	peterz@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] slab: __GFP_NOWARN not being propagated from mempool_alloc()
Date: Tue, 25 Nov 2008 00:47:33 +0200 (EET)	[thread overview]
Message-ID: <Pine.LNX.4.64.0811250038030.11825@melkki.cs.Helsinki.FI> (raw)
In-Reply-To: <E1L4jMt-0006OW-5J@pomaz-ex.szeredi.hu>

On Mon, 24 Nov 2008, Miklos Szeredi wrote:
> We see page allocation failure warnings on the mempool_alloc() path.
> See this lkml posting for example:
> 
> http://lkml.org/lkml/2008/10/27/100
> 
> The cause is that on NUMA, alloc_slabmgmt() clears __GFP_NOWARN,
> together with __GFP_THISNODE and __GFP_NORETRY.  But AFAICS it really
> only wants to clear __GFP_THISNODE.
> 
> Does this patch looks good?

Yes, it does but looking at mm/slab.c history I think we want something 
like the following instead. Christoph?

P.S. First one to test it gets a fabulous prize of a Tested-by tag in the 
patch description! How cool is that?

		Pekka

  reply	other threads:[~2008-11-24 22:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-24 21:53 Miklos Szeredi
2008-11-24 22:47 ` Pekka J Enberg [this message]
2008-11-25 18:58   ` Christoph Lameter
2008-11-26  8:10     ` Pekka Enberg
2008-11-26  9:50       ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0811250038030.11825@melkki.cs.Helsinki.FI \
    --to=penberg@cs.helsinki.fi \
    --cc=cl@linux-foundation.org \
    --cc=david@fromorbit.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=miklos@szeredi.hu \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox