From: Hugh Dickins <hugh@veritas.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
Nick Piggin <nickpiggin@yahoo.com.au>,
Linux Memory Management List <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH 1/2] mm: implement remap_pfn_range with apply_to_page_range
Date: Sat, 15 Nov 2008 09:28:37 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0811150914080.16789@blonde.site> (raw)
In-Reply-To: <491DBD9E.6030703@goop.org>
On Fri, 14 Nov 2008, Jeremy Fitzhardinge wrote:
> Nick Piggin wrote:
> > No, adding a cycle here or an indirect function call there IMO is
> > not acceptable in core mm/ code without a good reason.
>
> <shrug> OK.
I'm with Nick on this: admittedly remap_pfn_range() is a borderline
case (since it has no latency breaks at present), but it is a core
mm function, and I'd prefer we leave it as is unless good reason.
So, no hurry, but I'd prefer
mm-implement-remap_pfn_range-with-apply_to_page_range.patch
mm-remap_pfn_range-restore-missing-flush.patch
to be removed from mmotm - and don't I deserve that,
just for actually reading the mm-commits boilerplate ;-?
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-11-15 9:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-13 17:19 Jeremy Fitzhardinge
2008-11-13 19:53 ` Johannes Weiner
2008-11-13 20:12 ` Jeremy Fitzhardinge
2008-11-13 20:13 ` [PATCH 3/2] mm/remap_pfn_range: restore missing flush Jeremy Fitzhardinge
2008-11-14 2:19 ` [PATCH 1/2] mm: implement remap_pfn_range with apply_to_page_range Nick Piggin
2008-11-14 2:56 ` Jeremy Fitzhardinge
2008-11-14 3:17 ` Nick Piggin
2008-11-14 5:22 ` Jeremy Fitzhardinge
2008-11-14 7:35 ` Nick Piggin
2008-11-14 18:04 ` Jeremy Fitzhardinge
2008-11-15 9:28 ` Hugh Dickins [this message]
2008-11-17 3:03 ` Peter Chubb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0811150914080.16789@blonde.site \
--to=hugh@veritas.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nickpiggin@yahoo.com.au \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox