From: Hugh Dickins <hugh@veritas.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Willy Tarreau <w@1wt.eu>, Peter Cordes <peter@cordes.ca>,
Bodo Eggert <7eggert@gmx.de>,
David Newall <davidn@davidnewall.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH 2.6.28?] don't unlink an active swapfile
Date: Fri, 14 Nov 2008 18:02:26 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0811141758260.29362@blonde.site> (raw)
In-Reply-To: <20081114173422.GA22868@infradead.org>
On Fri, 14 Nov 2008, Christoph Hellwig wrote:
> On Fri, Nov 14, 2008 at 02:37:22AM +0000, Hugh Dickins wrote:
> > Peter Cordes is sorry that he rm'ed his swapfiles while they were in use,
> > he then had no pathname to swapoff. It's a curious little oversight, but
> > not one worth a lot of hackery. Kudos to Willy Tarreau for turning this
> > around from a discussion of synthetic pathnames to how to prevent unlink.
> > Mimic immutable: prohibit unlinking an active swapfile in may_delete()
> > (and don't worry my little head over the tiny race window).
>
> Looks good (but I think I already said this before)
Thanks. Indeed you did. I wondered whether to add an Acked-by in
your name, but I think different people have understandably different
positions on the etiquette of translating "Looks good" into "Acked-by";
so not knowing your position, I just Cc'ed you again.
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2008-11-14 18:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bnlDw-5vQ-7@gated-at.bofh.it>
[not found] ` <bnwpg-2EA-17@gated-at.bofh.it>
[not found] ` <bnJFK-3bu-7@gated-at.bofh.it>
2008-10-16 23:43 ` no way to swapoff a deleted swap file? Bodo Eggert
2008-10-16 23:43 ` Bodo Eggert
[not found] ` <bnR0A-4kq-1@gated-at.bofh.it>
2008-10-17 8:20 ` Bodo Eggert
2008-10-17 8:20 ` Bodo Eggert
2008-10-17 12:17 ` Hugh Dickins
2008-10-17 12:36 ` David Newall
2008-10-17 22:42 ` Bodo Eggert
2008-10-18 0:31 ` Peter Cordes
2008-10-18 5:18 ` Willy Tarreau
2008-10-18 20:45 ` Hugh Dickins
2008-10-18 20:49 ` Christoph Hellwig
2008-10-18 20:56 ` Willy Tarreau
2008-11-14 2:37 ` [PATCH 2.6.28?] don't unlink an active swapfile Hugh Dickins
2008-11-14 4:08 ` Peter Cordes
2008-11-14 17:34 ` Christoph Hellwig
2008-11-14 18:02 ` Hugh Dickins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0811141758260.29362@blonde.site \
--to=hugh@veritas.com \
--cc=7eggert@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=davidn@davidnewall.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peter@cordes.ca \
--cc=peterz@infradead.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox