From: Hugh Dickins <hugh@veritas.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Ingo Molnar <mingo@redhat.com>,
Arjan van de Ven <arjan@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH, RFC, v2] shmat: introduce flag SHM_MAP_HINT
Date: Tue, 7 Oct 2008 15:38:44 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0810071532280.29910@blonde.site> (raw)
In-Reply-To: <20081007112631.GH20740@one.firstfloor.org>
On Tue, 7 Oct 2008, Andi Kleen wrote:
> > I want say that we shouldn't do this check if shmaddr is a search hint.
> > I'm not sure that check is unneeded if shmadd is the exact address.
>
> mmap should fail in this case because it does the same check for
> MAP_FIXED. Obviously it cannot succeed when there is already something
> else there.
I'm not really following this, so forgive me if I'm reading you
out of context, but I think you're wrong on that...
The dangerous feature of mmap MAP_FIXED (why we don't usually use
it except within an address range we've already staked out earlier)
is that it does unmap whatever stands in its way. See the early
if (flags & MAP_FIXED)
return addr;
in arch_get_unmapped_area(), and the do_munmap() in mmap_region().
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-10-07 14:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 7:04 [PATCH] x86_64: Implement personality ADDR_LIMIT_32BIT Kirill A. Shutemov
2008-10-03 8:02 ` Ingo Molnar
2008-10-03 9:25 ` Kirill A. Shutemov
2008-10-03 12:44 ` Arjan van de Ven
2008-10-03 12:58 ` Kirill A. Shutemov
2008-10-06 6:13 ` Andi Kleen
2008-10-06 8:17 ` Kirill A. Shutemov
2008-10-06 8:42 ` Andi Kleen
2008-10-06 9:17 ` Kirill A. Shutemov
2008-10-06 9:56 ` Andi Kleen
2008-10-06 10:12 ` Kirill A. Shutemov
2008-10-06 13:26 ` Andi Kleen
2008-10-06 14:37 ` [PATCH, RFC] shmat: introduce flag SHM_MAP_HINT Kirill A. Shutemov
2008-10-06 19:29 ` Andi Kleen
2008-10-07 6:57 ` Kirill A. Shutemov
2008-10-07 6:57 ` [PATCH, RFC, v2] " Kirill A. Shutemov
2008-10-07 8:20 ` Andi Kleen
2008-10-07 10:09 ` Kirill A. Shutemov
2008-10-07 11:26 ` Andi Kleen
2008-10-07 11:23 ` Kirill A. Shutemov
2008-10-07 14:38 ` Hugh Dickins [this message]
2008-10-07 15:10 ` Andi Kleen
2008-10-07 11:08 ` [PATCH, RFC] " KOSAKI Motohiro
2008-10-07 11:21 ` Andi Kleen
2008-10-07 11:21 ` Kirill A. Shutemov
2008-10-07 11:26 ` KOSAKI Motohiro
2008-10-07 11:30 ` Kirill A. Shutemov
2008-10-07 11:50 ` Andi Kleen
2008-10-07 11:24 ` Kirill A. Shutemov
2008-10-07 12:31 ` Alan Cox
2008-10-07 13:14 ` Andi Kleen
2008-10-03 9:33 ` [PATCH] x86_64: Implement personality ADDR_LIMIT_32BIT Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0810071532280.29910@blonde.site \
--to=hugh@veritas.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=arjan@infradead.org \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox