From: Christoph Lameter <clameter@sgi.com>
To: npiggin@suse.de
Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
benh@kernel.crashing.org, paulus@samba.org
Subject: Re: [patch 3/7] mm: speculative page references
Date: Tue, 10 Jun 2008 12:08:27 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0806101205480.17798@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20080605094825.699347000@nick.local0.net>
On Thu, 5 Jun 2008, npiggin@suse.de wrote:
> + * do the right thing (see comments above).
> + */
> + return 0;
> + }
> +#endif
> + VM_BUG_ON(PageCompound(page) && (struct page *)page_private(page) != page);
This is easier written as:
== VM_BUG_ON(PageTail(page)
And its also slightly incorrect since page_private(page) is not pointing
to the head page for PageHead(page).
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-06-10 19:08 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 9:43 [patch 0/7] speculative page references, lockless pagecache, lockless gup npiggin
2008-06-05 9:43 ` [patch 1/7] mm: readahead scan lockless npiggin
2008-06-05 9:43 ` [patch 2/7] radix-tree: add gang_lookup_slot, gang_lookup_slot_tag npiggin
2008-06-05 9:43 ` [patch 3/7] mm: speculative page references npiggin
2008-06-06 14:20 ` Peter Zijlstra
2008-06-06 16:26 ` Nick Piggin
2008-06-06 16:27 ` Nick Piggin
2008-06-09 4:48 ` Tim Pepper
2008-06-10 19:08 ` Christoph Lameter [this message]
2008-06-11 3:19 ` Nick Piggin
2008-06-05 9:43 ` [patch 4/7] mm: lockless pagecache npiggin
2008-06-05 9:43 ` [patch 5/7] mm: spinlock tree_lock npiggin
2008-06-05 9:43 ` [patch 6/7] powerpc: implement pte_special npiggin
2008-06-06 4:04 ` Benjamin Herrenschmidt
2008-06-05 9:43 ` [patch 7/7] powerpc: lockless get_user_pages_fast npiggin
2008-06-09 8:32 ` Andrew Morton
2008-06-10 3:15 ` Nick Piggin
2008-06-10 19:00 ` Christoph Lameter
2008-06-11 3:18 ` Nick Piggin
2008-06-11 4:40 ` Christoph Lameter
2008-06-11 4:41 ` Christoph Lameter
2008-06-11 4:49 ` Nick Piggin
2008-06-11 6:06 ` Andrew Morton
2008-06-11 6:24 ` Nick Piggin
2008-06-11 6:50 ` Andrew Morton
2008-06-11 23:20 ` Christoph Lameter
2008-06-11 4:47 ` Nick Piggin
2008-06-05 11:53 ` [patch 0/7] speculative page references, lockless pagecache, lockless gup Nick Piggin
2008-06-05 17:33 ` Linus Torvalds
2008-06-06 0:08 ` Nick Piggin
2008-06-06 21:32 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0806101205480.17798@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
--cc=paulus@samba.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox