From: Hugh Dickins <hugh@veritas.com>
To: Willy Tarreau <w@1wt.eu>
Cc: Jan Engelhardt <jengelh@medozas.de>, Fede <fedux@lugmen.org.ar>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
Arjan van de Ven <arjan@infradead.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] Re: bad pmd ffff810000207238(9090909090909090).
Date: Wed, 28 May 2008 23:20:42 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0805282307520.29949@blonde.site> (raw)
In-Reply-To: <20080528204356.GA12687@1wt.eu>
On Wed, 28 May 2008, Willy Tarreau wrote:
> On Wed, May 28, 2008 at 10:14:31PM +0200, Jan Engelhardt wrote:
> > On Wednesday 2008-05-28 21:56, Willy Tarreau wrote:
> > >On Wed, May 28, 2008 at 07:36:07PM +0100, Hugh Dickins wrote:
> > >>
> > >> page on my x86_64 boxes, and they have lots of 0x90s there too.
> > >> It's just some page alignment filler that x86_64 kernel startup
> > >> has missed cleaning up - patch below fixes that. There's no
> > >
> > >Is there a particular reason we use 0x90 as an alignment filler ?
> >
> > Alignment within functions. You could use a JMP to jump over
> > the alignment, but that would be costly. So in order to
> > "run through the wall", you need an opcode that does not
> > do anything, something like 0x90.
>
> OK, I did not understand from Hugh's explanation that it was
> all about alignment within functions. Of course, 0x90 is fine
> there (though there are multi-byte NOPs available).
I'm hardly the right person to answer on this, but I believe that
because the 0x90 NOP is particularly appropriate in .text (and
prevents stalls even where it cannot be reached?), it gets used
as the default alignment filler all over. (It's even specified
for the arch-independent default _ALIGN in linux/linkage.h.)
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2008-05-28 22:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <483CBCDD.10401@lugmen.org.ar>
2008-05-28 18:36 ` Hugh Dickins
2008-05-28 18:40 ` Ingo Molnar
2008-05-28 19:56 ` Willy Tarreau
2008-05-28 20:14 ` Jan Engelhardt
2008-05-28 20:43 ` Willy Tarreau
2008-05-28 21:24 ` Jan Engelhardt
2008-05-28 22:20 ` Hugh Dickins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0805282307520.29949@blonde.site \
--to=hugh@veritas.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=fedux@lugmen.org.ar \
--cc=hirofumi@mail.parknet.co.jp \
--cc=jengelh@medozas.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox