make vmstat cpu-unplug safe

make vmstat cpu-unplug safe

[KOSAKI Motohiro]

btw: I think all_vm_event() author is Cristoph Lameter, right?


--------------------------------------------
When access cpu_online_map, We should prevent that dynamically 
change cpu_online_map by get_online_cpus().

Unfortunately, all_vm_events() doesn't it.

Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
CC: Christoph Lameter <clameter@sgi.com>

---
 mm/vmstat.c |    2 ++
 1 file changed, 2 insertions(+)

Index: b/mm/vmstat.c
===================================================================
--- a/mm/vmstat.c       2008-05-04 23:00:52.000000000 +0900
+++ b/mm/vmstat.c       2008-05-06 16:13:32.000000000 +0900
@@ -42,7 +42,9 @@ static void sum_vm_events(unsigned long
 */
 void all_vm_events(unsigned long *ret)
 {
+       get_online_cpus();
        sum_vm_events(ret, &cpu_online_map);
+       put_online_cpus();
 }
 EXPORT_SYMBOL_GPL(all_vm_events);



--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: make vmstat cpu-unplug safe

[Christoph Lameter]

On Tue, 6 May 2008, KOSAKI Motohiro wrote:
 
> btw: I think all_vm_event() author is Cristoph Lameter, right?

Welll I am the last one who reworked it from earlier incarnations.

> When access cpu_online_map, We should prevent that dynamically 
> change cpu_online_map by get_online_cpus().
> 
> Unfortunately, all_vm_events() doesn't it.

Acked-by: Christoph Lameter <clameter@sgi.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>