From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 8 Apr 2008 13:55:46 -0700 (PDT) From: Christoph Lameter Subject: Re: [patch 04/12] slub: Add kmem_cache_order_objects struct In-Reply-To: <47FA4507.6090409@cs.helsinki.fi> Message-ID: References: <20080404225019.369359572@sgi.com> <20080404225104.311511519@sgi.com> <47FA4507.6090409@cs.helsinki.fi> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Pekka Enberg Cc: Matt Mackall , Nick Piggin , linux-mm@kvack.org List-ID: On Mon, 7 Apr 2008, Pekka Enberg wrote: > Hi Christoph, > > Christoph Lameter wrote: > > @@ -1143,7 +1165,7 @@ static struct page *new_slab(struct kmem > > start = page_address(page); > > if (unlikely(s->flags & SLAB_POISON)) > > - memset(start, POISON_INUSE, PAGE_SIZE << s->order); > > + memset(start, POISON_INUSE, PAGE_SIZE << oo_order(oo)); > > This should be compound_order(page) as allocate_slab() can fall back to > smaller page order. Ack. I distinctly remember fixing this once before. Sigh. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org