From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Lameter Subject: [ofa-general] Re: [patch 1/9] EMM Notifier: The notifier calls Date: Wed, 2 Apr 2008 14:54:52 -0700 (PDT) Message-ID: References: <20080401205531.986291575@sgi.com> <20080401205635.793766935@sgi.com> <20080402064952.GF19189@duo.random> <20080402215334.GT19189@duo.random> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: In-Reply-To: <20080402215334.GT19189@duo.random> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: general-bounces@lists.openfabrics.org Errors-To: general-bounces@lists.openfabrics.org To: Andrea Arcangeli Cc: Nick Piggin , steiner@sgi.com, Peter Zijlstra , linux-mm@kvack.org, Izik Eidus , Kanoj Sarcar , Roland Dreier , linux-kernel@vger.kernel.org, Avi Kivity , kvm-devel@lists.sourceforge.net, daniel.blueman@quadrics.com, Robin Holt , general@lists.openfabrics.org, Hugh Dickins List-Id: linux-mm.kvack.org On Wed, 2 Apr 2008, Andrea Arcangeli wrote: > > Hmmm... Okay that is one solution that would just require a BUG_ON in the > > registration methods. > > Perhaps you didn't notice that this solution can't work if you call > range_begin/end not in the "current" context and try_to_unmap_cluster > does exactly that for both my patchset and yours. Missing an _end is > ok, missing a _begin is never ok. If you look at the patch you will see a requirement of holding a writelock on mmap_sem which will keep out get_user_pages().