From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Sat, 1 Mar 2008 11:59:30 +0200 (EET) From: Pekka J Enberg Subject: Re: [patch 08/10] slub: Remove BUG_ON() from ksize and omit checks for !SLUB_DEBUG In-Reply-To: Message-ID: References: <20080229043401.900481416@sgi.com> <20080229043553.076119937@sgi.com> <47C7B826.4090603@cs.helsinki.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: Matt Mackall , linux-mm@kvack.org List-ID: On Fri, 29 Feb 2008, Pekka Enberg wrote: > > Why are you wrapping the SLAB_DESTORY_BY_RCU case with CONFIG_SLUB_DEBUG too? On Fri, 29 Feb 2008, Christoph Lameter wrote: > Mistake on my part. Corrected patch follows: > > From 74d3c465f217f3103e7a6d21cb090497386de8be Mon Sep 17 00:00:00 2001 > From: Christoph Lameter > Date: Fri, 15 Feb 2008 23:45:25 -0800 > Subject: [PATCH] slub: Remove BUG_ON() from ksize and omit checks for !SLUB_DEBUG > > The BUG_ONs are useless since the pointer derefs will lead to > NULL deref errors anyways. Some of the checks are not necessary > if no debugging is possible. > > Signed-off-by: Christoph Lameter Reviewed-by: Pekka Enberg -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org