From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 8 Feb 2008 10:32:41 -0800 (PST) From: Christoph Lameter Subject: Re: [PATCH] mm/slub.c - Use print_hex_dump In-Reply-To: <1202495069.27394.85.camel@localhost> Message-ID: References: <1202493808.27394.76.camel@localhost> <1202495069.27394.85.camel@localhost> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Joe Perches Cc: Pekka Enberg , linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: On Fri, 8 Feb 2008, Joe Perches wrote: > On Fri, 2008-02-08 at 10:07 -0800, Christoph Lameter wrote: > > On Fri, 8 Feb 2008, Joe Perches wrote: > > > Use the library function to dump memory > > Could you please compare the formatting of the output before and > > after? Last time we tried this we had issues because it became a bit ugly. > > The difference is the last line of the ascii is not aligned > if the length is non modulo 16. > > I have sent a patch to print_hex_dump to always align. > http://lkml.org/lkml/2007/12/6/304 Could you group these together for review? I think we are okay with the slub changes if the print_hex_dump is fixed. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org