linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Lameter <clameter@sgi.com>
To: Dhaval Giani <dhaval@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	htejun@gmail.com, Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>,
	Balbir Singh <balbir@in.ibm.com>,
	maneesh@linux.vnet.ibm.com, lkml <linux-kernel@vger.kernel.org>,
	linux-mm@kvack.org
Subject: Re: 2.6.22-stable causes oomkiller to be invoked
Date: Wed, 2 Jan 2008 13:54:12 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0801021346580.3778@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0801021237330.21526@schroedinger.engr.sgi.com>

Just traced it again on my system: It is okay for the number of pages on 
the quicklist to reach the high count that we see (although the 16 bit 
limits are weird. You have around 4GB of memory in the system?). Up to 
1/16th of free memory of a node can be allocated for quicklists (this 
allows the effective shutting down and restarting of large amounts of 
processes)

The problem may be that this is run on a HIGHMEM system and the 
calculation of allowable pages on the quicklists does not take into 
account that highmem pages are not usable for quicklists (not sure about 
ZONE_MOVABLE on i386. Maybe we need to take that into account as well?)

Here is a patch that removes the HIGHMEM portion from the calculation. 
Does this change anything:

Index: linux-2.6/mm/quicklist.c
===================================================================
--- linux-2.6.orig/mm/quicklist.c	2008-01-02 13:41:10.000000000 -0800
+++ linux-2.6/mm/quicklist.c	2008-01-02 13:44:15.000000000 -0800
@@ -29,6 +29,12 @@ static unsigned long max_pages(unsigned 
 
 	node_free_pages = node_page_state(numa_node_id(),
 			NR_FREE_PAGES);
+#ifdef CONFIG_HIGHMEM
+	/* Take HIGHMEM pages out of consideration */
+	node_free_pages -= zone_page_state(&NODE_DATA(numa_node_id())->node_zones[ZONE_HIGHMEM],
+				NR_FREE_PAGES);
+#endif
+
 	max = node_free_pages / FRACTION_OF_NODE_MEM;
 	return max(max, min_pages);
 }

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2008-01-02 21:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20071213132326.GC16905@linux.vnet.ibm.com>
     [not found] ` <20071213151847.GB5676@linux.vnet.ibm.com>
     [not found]   ` <20071213162936.GA7635@suse.de>
     [not found]     ` <20071213164658.GA30865@linux.vnet.ibm.com>
     [not found]       ` <20071213175423.GA2977@linux.vnet.ibm.com>
     [not found]         ` <476295FF.1040202@gmail.com>
     [not found]           ` <20071214154711.GD23670@linux.vnet.ibm.com>
     [not found]             ` <4762A721.7080400@gmail.com>
     [not found]               ` <20071214161637.GA2687@linux.vnet.ibm.com>
     [not found]                 ` <20071214095023.b5327703.akpm@linux-foundation.org>
     [not found]                   ` <20071214182802.GC2576@linux.vnet.ibm.com>
2007-12-14 23:05                     ` Andrew Morton
2007-12-15  3:52                       ` Dhaval Giani
2007-12-15  6:00                         ` Andrew Morton
2007-12-15 10:44                           ` Dhaval Giani
     [not found]                             ` <20071217045904.GB31386@linux.vnet.ibm.com>
     [not found]                               ` <Pine.LNX.4.64.0712171143280.12871@schroedinger.engr.sgi.com>
     [not found]                                 ` <20071217120720.e078194b.akpm@linux-foundation.org>
     [not found]                                   ` <Pine.LNX.4.64.0712171222470.29500@schroedinger.engr.sgi.com>
2007-12-21  4:45                                     ` Dhaval Giani
2007-12-26 21:01                                       ` Christoph Lameter
     [not found]                                         ` <Pine.LNX.4.64.0712271119030.30555@schroedinger.engr.sgi.com>
2007-12-28 10:11                                           ` Dhaval Giani
2008-01-02 20:45                                             ` Christoph Lameter
2008-01-02 21:54                                               ` Christoph Lameter [this message]
2008-01-03  3:59                                                 ` Dhaval Giani
2008-01-03  4:16                                                   ` Dhaval Giani
2008-01-03 21:04                                                     ` Christoph Lameter
2008-01-07 20:04                                                       ` Christoph Lameter
2008-01-08  4:33                                                         ` Dhaval Giani
2007-12-30 14:01                                         ` Ingo Molnar
2007-12-30 19:24                                           ` Dhaval Giani
2008-01-02 20:48                                           ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0801021346580.3778@schroedinger.engr.sgi.com \
    --to=clameter@sgi.com \
    --cc=akpm@linux-foundation.org \
    --cc=balbir@in.ibm.com \
    --cc=dhaval@linux.vnet.ibm.com \
    --cc=htejun@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maneesh@linux.vnet.ibm.com \
    --cc=vatsa@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox