From: Christoph Lameter <clameter@sgi.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: andi@firstfloor.org, travis@sgi.com, ak@suse.de,
pageexec@freemail.hu, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] mm: Prevent dereferencing non-allocated per_cpu variables
Date: Tue, 27 Nov 2007 15:22:56 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0711271522050.6713@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20071127152122.1d5fbce3.akpm@linux-foundation.org>
On Tue, 27 Nov 2007, Andrew Morton wrote:
> The prefetch however might still need some work - we can indeed do
> prefetch() against a not-possible CPU's memory here. And I do recall that
> 4-5 years ago we did have a CPU (one of mine, iirc) which would oops when
> prefetching from a bad address. I forget what the conclusion was on that
> matter.
>
> If we do want to fix the prefetch-from-outer-space then we should be using
> cpu_isset(cpu, *cpumask) here rather than cpu_possible().
Generally the prefetch things have turned out to be not that useful. How
about dropping the prefetch? I kept it because it was there.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-11-27 23:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071127215052.090968000@sgi.com>
2007-11-27 21:50 ` travis
2007-11-27 22:01 ` pageexec
2007-11-27 22:16 ` Andi Kleen
2007-11-27 23:12 ` Andrew Morton
2007-11-27 23:15 ` Christoph Lameter
2007-11-27 23:21 ` Andrew Morton
2007-11-27 23:22 ` Christoph Lameter [this message]
2007-11-27 23:42 ` Andrew Morton
2007-11-27 23:48 ` Andi Kleen
2007-11-28 0:15 ` Christoph Lameter
2007-11-28 0:09 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0711271522050.6713@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pageexec@freemail.hu \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox