From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 27 Nov 2007 08:36:41 +0000 (GMT) From: Hugh Dickins Subject: Re: [PATCH][SHMEM] Factor out sbi->free_inodes manipulations In-Reply-To: <20071126212311.88818502.akpm@linux-foundation.org> Message-ID: References: <4745B4F2.3060308@openvz.org> <20071126212311.88818502.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Andrew Morton Cc: Pavel Emelyanov , Linux MM , Linux Kernel Mailing List , devel@openvz.org List-ID: On Mon, 26 Nov 2007, Andrew Morton wrote: > > It is peculair to (wrongly) return -ENOMEM > > > + if (shmem_reserve_inode(inode->i_sb)) > > + return -ENOSPC; > > and to then correct it in the caller.. Oops, I missed that completely. > Something boringly conventional such as the below, perhaps? Much better, thanks. Hugh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org