From: Hugh Dickins <hugh@veritas.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Pavel Emelyanov <xemul@openvz.org>, Linux MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devel@openvz.org
Subject: Re: [PATCH][SHMEM] Factor out sbi->free_inodes manipulations
Date: Tue, 27 Nov 2007 08:36:41 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0711270835170.19731@blonde.wat.veritas.com> (raw)
In-Reply-To: <20071126212311.88818502.akpm@linux-foundation.org>
On Mon, 26 Nov 2007, Andrew Morton wrote:
>
> It is peculair to (wrongly) return -ENOMEM
>
> > + if (shmem_reserve_inode(inode->i_sb))
> > + return -ENOSPC;
>
> and to then correct it in the caller..
Oops, I missed that completely.
> Something boringly conventional such as the below, perhaps?
Much better, thanks.
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2007-11-27 8:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-22 16:57 Pavel Emelyanov
2007-11-23 13:41 ` Hugh Dickins
2007-11-23 13:53 ` Pavel Emelyanov
2007-11-27 5:23 ` Andrew Morton
2007-11-27 8:36 ` Hugh Dickins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0711270835170.19731@blonde.wat.veritas.com \
--to=hugh@veritas.com \
--cc=akpm@linux-foundation.org \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox