From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 2 Oct 2007 11:29:51 -0700 (PDT) From: Christoph Lameter Subject: Re: [Patch / 002](memory hotplug) Callback function to create kmem_cache_node. In-Reply-To: <20071002105422.2790.Y-GOTO@jp.fujitsu.com> Message-ID: References: <20071001183316.7A9B.Y-GOTO@jp.fujitsu.com> <20071002105422.2790.Y-GOTO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Yasunori Goto Cc: Andrew Morton , Linux Kernel ML , linux-mm List-ID: On Tue, 2 Oct 2007, Yasunori Goto wrote: > Do you mean that just nr_slabs should be checked like followings? > I'm not sure this is enough. > > : > if (s->node[nid]) { > n = get_node(s, nid); > if (!atomic_read(&n->nr_slabs)) { > s->node[nid] = NULL; > kmem_cache_free(kmalloc_caches, n); > } > } > : > : That would work. But it would be better to shrink the cache first. The first 2 slabs on a node may be empty and the shrinking will remove those. If you do not shrink then the code may falsely assume that there are objects on the node. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org