From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 20 Sep 2007 15:05:43 -0700 (PDT) From: Christoph Lameter Subject: Re: [patch 4/9] oom: add per-zone locking In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: David Rientjes Cc: Andrew Morton , Andrea Arcangeli , Rik van Riel , linux-mm@kvack.org List-ID: On Thu, 20 Sep 2007, David Rientjes wrote: > On Thu, 20 Sep 2007, Christoph Lameter wrote: > > > > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > > > --- a/mm/oom_kill.c > > > +++ b/mm/oom_kill.c > > > @@ -27,6 +27,7 @@ > > > #include > > > > > > int sysctl_panic_on_oom; > > > +static DEFINE_MUTEX(zone_scan_mutex); > > > /* #define DEBUG */ > > > > Use testset/testclear bitops instead of adding a lock? > > > > That doesn't work nicely, unfortunately, because then we need to unlock > all zones that we've locked so far in try_set_zone_oom() if we find one > that is alredy ZONE_OOM_LOCKED during the scan of the zonelist. You need that lock release function anyways to when the oom killing is done. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org