From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 19 Sep 2007 11:57:59 -0700 (PDT) From: Christoph Lameter Subject: Re: [patch 7/8] oom: only kill tasks that share zones with zonelist In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: David Rientjes Cc: Andrew Morton , Andrea Arcangeli , Rik van Riel , linux-mm@kvack.org, pj@sgi.com List-ID: On Wed, 19 Sep 2007, David Rientjes wrote: > + for (vma = mm->mmap; vma; vma = vma->vm_next) { > + unsigned long pfn; > + struct zone *zone; > + > + pfn = PFN_DOWN(vma->vm_start); > + zone = page_zone(pfn_to_page(pfn)); This seems to assume that all pages in a vma are in the same zone? That is not the case. On a NUMA system pages may be allocated round robin. Meaning lots of zones are used that this approach does not catch. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org