Re: [PATCH/RFC] Add node states sysfs class attributeS - V4

[Christoph Lameter <clameter@sgi.com>]

On Thu, 30 Aug 2007, Lee Schermerhorn wrote:

> Try, try again.  Maybe closer this time.

Yes. Thanks for all your work on this.

> Question:  do we need/want to display the normal and high memory masks
> separately for systems with HIGHMEM?  If not, I'd suggest changing the
> print_nodes_state() function to take a nodemask_t* instead of a state
> enum and expose a single 'has_memory' attribute that we print using
> something like:

No leave it separate.

> 
> static ssize_t print_nodes_has_memory(struct sysdev_class *class,
> 						char *buf)
> {
> 	nodemask_t has_memory = node_states[N_NORMAL_MEMORY];
> 
> 	if (N_HIGH_MEMORY - N_NORMAL_MEMORY)

Uggg. Better do #ifdef CONFIG_HIGHMEM

> 		nodes_or(has_memory, has_memory, node_states[N_HIGH_MEMORY]);
> 
> 	return print_nodes_state(&has_memory, buf);

> + * node states attributes
> + */
> +
> +static ssize_t print_nodes_state(enum node_states state, char *buf)
> +{
> +	int n;
> +
> +	n = nodelist_scnprintf(buf, PAGE_SIZE, node_states[state]);
> +	if (n <= 0)
> +		goto done;
> +	if (PAGE_SIZE - n > 1) {

if (n > 0 && PAGE_SIZE > n + 1)

?
> +		*(buf + n++) = '\n';
> +		*(buf + n++) = '\0';
> +	}

> +static ssize_t print_nodes_possible(struct sysdev_class *class, char *buf)
> +{
> +	return print_nodes_state(N_POSSIBLE, buf);
> +}
> +
> +static ssize_t print_nodes_online(struct sysdev_class *class, char *buf)
> +{
> +	return print_nodes_state(N_ONLINE, buf);
> +}
> +
> +static ssize_t print_nodes_has_normal_memory(struct sysdev_class *class,
> +						char *buf)
> +{
> +	return print_nodes_state(N_NORMAL_MEMORY, buf);
> +}
> +
> +static ssize_t print_nodes_has_cpu(struct sysdev_class *class, char *buf)
> +{
> +	return print_nodes_state(N_CPU, buf);
> +}
> +
> +static SYSDEV_CLASS_ATTR(possible, 0444, print_nodes_possible, NULL);
> +static SYSDEV_CLASS_ATTR(online, 0444, print_nodes_online, NULL);
> +static SYSDEV_CLASS_ATTR(has_normal_memory, 0444, print_nodes_has_normal_memory,

I am sure that there is some way to dynamicall allocate these.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>