From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 16 Aug 2007 11:33:09 -0700 (PDT) From: Christoph Lameter Subject: Re: [PATCH/RFC] memoryless nodes - fixup uses of node_online_map in generic code In-Reply-To: <1187273853.5900.21.camel@localhost> Message-ID: References: <20070727194316.18614.36380.sendpatchset@localhost> <20070727194322.18614.68855.sendpatchset@localhost> <20070731192241.380e93a0.akpm@linux-foundation.org> <20070731200522.c19b3b95.akpm@linux-foundation.org> <20070731203203.2691ca59.akpm@linux-foundation.org> <1185977011.5059.36.camel@localhost> <1186085994.5040.98.camel@localhost> <1186611582.5055.95.camel@localhost> <1187273853.5900.21.camel@localhost> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Lee Schermerhorn Cc: Andrew Morton , ak@suse.de, linux-mm@kvack.org, Nishanth Aravamudan , pj@sgi.com, kxr@sgi.com, Mel Gorman , KAMEZAWA Hiroyuki , Eric Whitney List-ID: On Thu, 16 Aug 2007, Lee Schermerhorn wrote: > Note questions about use of N_HIGH_MEMORY in find_next_best_node() and > population of N_HIGH_MEMORY in early_calculate_totalpages(). > > Comments? The changes in early_calculate_totalpages duplicate the setting of the bit in the N_HIGH_MEMORY map. But that could be removed with an additional patch if we are sure that early_calculate_totalpages is always called. Otherwise it looks fine. Acked-by: Christoph Lameter > mm/page_alloc.c:find_next_best_node() > > skip nodes w/o memory. > N_HIGH_MEMORY state mask may not be initialized at this time, > unless we want to depend on early_calculate_totalpages() [see > below]. Will ZONE_MOVABLE ever be configurable? Hopefully it will be removed at some point. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org