From: Christoph Lameter <clameter@sgi.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
Subject: Re: SLUB: Fix dynamic dma kmalloc cache creation
Date: Fri, 10 Aug 2007 10:40:15 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0708101037290.12758@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20070810004059.8aa2aadb.akpm@linux-foundation.org>
On Fri, 10 Aug 2007, Andrew Morton wrote:
> Well that was fairly foul. What was wrong wih turning slub_lock into a
> spinlock?
It would make things even worse because we would have always to do atomic
allocs when holding the lock. Or allocate before and then take the
lock to check if someone else has created it. If so we would need to fall
back meaning we cannot avoid kmem_cache_destroy() from dynamic cache
creation. The trylock avoids the kmem_cache_destroy() and is minimally
invasive.
> > + schedule_work(&sysfs_add_work);
>
> sysfs_add_work could be already pending, or running. boom.
sysfs_add_work takes the slub_lock. It cannot be running.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-08-10 17:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200708100559.l7A5x3r2019930@hera.kernel.org>
2007-08-10 7:40 ` Andrew Morton
2007-08-10 17:40 ` Christoph Lameter [this message]
2007-08-10 18:40 ` Andrew Morton
2007-08-10 18:52 ` Christoph Lameter
2007-08-10 18:37 ` Christoph Lameter
2007-08-10 18:53 ` Andrew Morton
2007-08-10 20:55 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0708101037290.12758@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox