From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 2 Aug 2007 14:24:44 +0200 (CEST) From: Jan Engelhardt Subject: Re: [PATCH] type safe allocator In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Alexey Dobriyan Cc: Miklos Szeredi , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, torvalds@linux-foundation.org List-ID: On Aug 2 2007 16:04, Alexey Dobriyan wrote: >On 8/2/07, Miklos Szeredi wrote: >> fooptr = kmalloc(sizeof(struct foo), ...); > >Key word is "traditional". Good traditional form which even half-competent >C programmers immediately parse in retina. And being aware of the potential type-unsafety makes programmers more careful IMHO. > >> +/** >> + * alloc_struct - allocate given type object >> + * @type: the type of the object to allocate >> + * @flags: the type of memory to allocate. >> + */ >> +#define alloc_struct(type, flags) ((type *) kmalloc(sizeof(type), flags)) >someone will write alloc_struct(int, GFP_KERNEL), I promise. and someone else will write struct complexthing foo; alloc_struct(foo, GFP_KERNEL); Jan -- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org