SLUB: Style fix up the loop to disable small slabs

SLUB: Style fix up the loop to disable small slabs

[Christoph Lameter]

Do proper spacing and we only need to do this in steps of 8.

Signed-off-by: Christoph Lameter <clameter@sgi.com>

---
 mm/slub.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.22-rc6-mm1/mm/slub.c
===================================================================
--- linux-2.6.22-rc6-mm1.orig/mm/slub.c	2007-07-03 17:27:22.000000000 -0700
+++ linux-2.6.22-rc6-mm1/mm/slub.c	2007-07-03 17:27:34.000000000 -0700
@@ -2600,7 +2600,7 @@ void __init kmem_cache_init(void)
 	BUILD_BUG_ON(KMALLOC_MIN_SIZE > 256 ||
 		(KMALLOC_MIN_SIZE & (KMALLOC_MIN_SIZE - 1)));
 
-	for (i = 8; i < KMALLOC_MIN_SIZE;i++)
+	for (i = 8; i < KMALLOC_MIN_SIZE; i += 8)
 		size_index[(i - 1) / 8] = KMALLOC_SHIFT_LOW;
 
 	slab_state = UP;

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: SLUB: Style fix up the loop to disable small slabs

[Andrew Morton]

ugh, six slab patches, no sequence numbers.

What is the applying order?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: SLUB: Style fix up the loop to disable small slabs

[Christoph Lameter]

On Fri, 6 Jul 2007, Andrew Morton wrote:

> ugh, six slab patches, no sequence numbers.
> 
> What is the applying order?

Below the order in which they were sent. They should apply that 
way. The only dependencies AFAIK is that 4 depends on 3.

1. SLUB: Style fix up the loop to disable small slabs
2. SLUB: Do not use length parameter in slab_alloc()
3. Slab allocators: Cleanup zeroing allocations
4. Slab allocators: Replace explicit zeroing with __GF
5. SLUB: Do not allocate object bit array on stack
6. SLUB: Move sysfs operations outside of slub_lock
7. SLUB: Fix CONFIG_SLUB_DEBUG use for CONFIG_NUMA

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>