From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 26 Jun 2007 11:23:30 -0700 (PDT) From: Christoph Lameter Subject: Re: [patch 21/26] Slab defragmentation: support dentry defragmentation In-Reply-To: <20070626011845.bfd4efe0.akpm@linux-foundation.org> Message-ID: References: <20070618095838.238615343@sgi.com> <20070618095918.404020641@sgi.com> <20070626011845.bfd4efe0.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Pekka Enberg , suresh.b.siddha@intel.com List-ID: On Tue, 26 Jun 2007, Andrew Morton wrote: > > + * objects. > > + */ > > + abort = 1; > > It's unobvious why the entire shrink effort is abandoned if one busy dentry > is encountered. Please flesh the comment out explaining this. If one item is busy then we cannot reclaim the slab. So what would be the use of continuing efforts. I thought I put that into the description? I can put that into the code too. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org