From: Christoph Lameter <clameter@sgi.com>
To: Mel Gorman <mel@csn.ul.ie>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kamezawa.hiroyu@jp.fujitsu.com
Subject: Re: [PATCH 1/7] KAMEZAWA Hiroyuki hot-remove patches
Date: Mon, 18 Jun 2007 09:56:20 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0706180954320.4751@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20070618092841.7790.48917.sendpatchset@skynet.skynet.ie>
On Mon, 18 Jun 2007, Mel Gorman wrote:
> @@ -632,18 +632,27 @@ static int unmap_and_move(new_page_t get
> goto unlock;
> wait_on_page_writeback(page);
> }
> -
> + /* anon_vma should not be freed while migration. */
> + if (PageAnon(page)) {
> + rcu_read_lock();
> + rcu_locked = 1;
> + }
We agreed on doing rcu_read_lock removing the status variable
and checking for PageAnon(). Doing so deuglifies the
function.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-06-18 16:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-18 9:28 [PATCH 0/7] Memory Compaction v2 Mel Gorman
2007-06-18 9:28 ` [PATCH 1/7] KAMEZAWA Hiroyuki hot-remove patches Mel Gorman
2007-06-18 16:56 ` Christoph Lameter [this message]
2007-06-19 15:52 ` Mel Gorman
2007-06-18 9:29 ` [PATCH 2/7] Allow CONFIG_MIGRATION to be set without CONFIG_NUMA Mel Gorman
2007-06-18 17:04 ` Christoph Lameter
2007-06-19 15:59 ` Mel Gorman
2007-06-18 9:29 ` [PATCH 3/7] Introduce isolate_lru_page_nolock() as a lockless version of isolate_lru_page() Mel Gorman
2007-06-18 17:05 ` Christoph Lameter
2007-06-18 9:29 ` [PATCH 4/7] Provide metrics on the extent of fragmentation in zones Mel Gorman
2007-06-18 17:07 ` Christoph Lameter
2007-06-18 9:30 ` [PATCH 5/7] Introduce a means of compacting memory within a zone Mel Gorman
2007-06-18 17:18 ` Christoph Lameter
2007-06-19 16:36 ` Mel Gorman
2007-06-19 19:20 ` Christoph Lameter
2007-06-19 12:54 ` Yasunori Goto
2007-06-19 16:49 ` Mel Gorman
2007-06-18 9:30 ` [PATCH 6/7] Add /proc/sys/vm/compact_node for the explicit compaction of a node Mel Gorman
2007-06-18 9:30 ` [PATCH 7/7] Compact memory directly by a process when a high-order allocation fails Mel Gorman
2007-06-18 17:22 ` Christoph Lameter
2007-06-19 16:50 ` Mel Gorman
2007-06-21 12:28 ` Andrew Morton
2007-06-21 13:26 ` Mel Gorman
2007-06-18 17:24 ` [PATCH 0/7] Memory Compaction v2 Christoph Lameter
2007-06-19 16:58 ` Mel Gorman
2007-06-19 19:22 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0706180954320.4751@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox