From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 15 Jun 2007 07:35:43 -0700 (PDT) From: Christoph Lameter Subject: Re: [RFC] memory unplug v5 [5/6] page unplug In-Reply-To: Message-ID: References: <20070614155630.04f8170c.kamezawa.hiroyu@jp.fujitsu.com> <20070614160458.62e20cbd.kamezawa.hiroyu@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Andy Whitcroft Cc: David Rientjes , KAMEZAWA Hiroyuki , linux-mm@kvack.org, mel@csn.ul.ie, y-goto@jp.fujitsu.com, hugh@veritas.com List-ID: On Thu, 14 Jun 2007, David Rientjes wrote: > > + struct zone *zone = NULL; > > + struct page *page; > > + for (pfn = start_pfn; > > + pfn < end_pfn; > > + pfn += MAX_ORDER_NR_PAGES) { > > +#ifdef CONFIG_HOLES_IN_ZONE > > + int i; > > + for (i = 0; i < MAX_ORDER_NR_PAGES; i++) { > > + if (pfn_valid_within(pfn + i)) > > + break; > > + } > > + if (i == MAX_ORDER_NR_PAGES) > > + continue; > > + page = pfn_to_page(pfn + i); > > +#else > > + page = pfn_to_page(pfn); > > +#endif > > Please extract this out to inlined functions that are conditional are > CONFIG_HOLES_IN_ZONE. And we need to deal with HOLES_IN_ZONE because the sparsemem virtual memmap patchset was not merged and therefore we cannot get rid of VIRTUAL_MEM_MAP. Andy, any progress? Do you want me to do another patchset? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org