From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 12 Jun 2007 14:25:47 -0700 (PDT) From: Christoph Lameter Subject: Re: [patch 2/3] Fix GFP_THISNODE behavior for memoryless nodes In-Reply-To: Message-ID: References: <20070612204843.491072749@sgi.com> <20070612205738.548677035@sgi.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: David Rientjes Cc: akpm@linux-foundation.org, linux-mm@kvack.org, ak@suse.de, Nishanth Aravamudan , Lee Schermerhorn List-ID: On Tue, 12 Jun 2007, David Rientjes wrote: > That's the point. Isn't !node_memory(nid) unlikely? Correct. Use unlikely Signed-off-cy: Christoph Lameter Index: linux-2.6.22-rc4-mm2/include/linux/gfp.h =================================================================== --- linux-2.6.22-rc4-mm2.orig/include/linux/gfp.h 2007-06-12 14:22:57.000000000 -0700 +++ linux-2.6.22-rc4-mm2/include/linux/gfp.h 2007-06-12 14:24:46.000000000 -0700 @@ -179,7 +179,7 @@ static inline struct page *alloc_pages_n * Check for the special case that GFP_THISNODE is used on a * memoryless node */ - if ((gfp_mask & __GFP_THISNODE) && !node_memory(nid)) + if (unlikely((gfp_mask & __GFP_THISNODE) && !node_memory(nid))) return NULL; return __alloc_pages(gfp_mask, order, -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org