Re: [patch 1/3] NUMA: introduce node_memory_map

[Christoph Lameter <clameter@sgi.com>]

On Tue, 12 Jun 2007, David Rientjes wrote:

> >   * int node_online(node)		Is some node online?
> >   * int node_possible(node)		Is some node possible?
> > + * int node_memory(node)		Does a node have memory?
> >   *
> 
> This name doesn't make sense; wouldn't node_has_memory() be better?

node_set_has_memory and node_clear_has_memory sounds a bit strange.

> 
> >   * int any_online_node(mask)		First online node in mask
> >   *
> >   * node_set_online(node)		set bit 'node' in node_online_map
> >   * node_set_offline(node)		clear bit 'node' in node_online_map
> >   *
> > + * node_set_memory(node)		set bit 'node' in node_memory_map
> > + * node_clear_memoryd(node)		clear bit 'node' in node_memory_map
> > + *
> 
> Extra 'd' there in node_clear_memory().

Tss.... It survived my editing.

Fix typo

Signed-off-by: Christoph Lameter <clameter@sgi.com>

Index: linux-2.6.22-rc4-mm2/include/linux/nodemask.h
===================================================================
--- linux-2.6.22-rc4-mm2.orig/include/linux/nodemask.h	2007-06-12 14:07:52.000000000 -0700
+++ linux-2.6.22-rc4-mm2/include/linux/nodemask.h	2007-06-12 14:08:03.000000000 -0700
@@ -72,7 +72,7 @@
  * node_set_offline(node)		clear bit 'node' in node_online_map
  *
  * node_set_memory(node)		set bit 'node' in node_memory_map
- * node_clear_memoryd(node)		clear bit 'node' in node_memory_map
+ * node_clear_memory(node)		clear bit 'node' in node_memory_map
  *
  * for_each_node(node)			for-loop node over node_possible_map
  * for_each_online_node(node)		for-loop node over node_online_map
 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>