From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 11 Jun 2007 17:41:15 -0700 (PDT) From: Christoph Lameter Subject: Re: [PATCH] populated_map: fix !NUMA case, remove comment In-Reply-To: <20070612000705.GH14458@us.ibm.com> Message-ID: References: <20070611202728.GD9920@us.ibm.com> <20070611221036.GA14458@us.ibm.com> <20070611225213.GB14458@us.ibm.com> <20070611234155.GG14458@us.ibm.com> <20070612000705.GH14458@us.ibm.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Nishanth Aravamudan Cc: lee.schermerhorn@hp.com, anton@samba.org, akpm@linux-foundation.org, linux-mm@kvack.org List-ID: On Mon, 11 Jun 2007, Nishanth Aravamudan wrote: > > No need to initialize if we do not use it. You may to #ifdef it out > > by moving the definition. Please sent a diff against the earlier patch > > since Andrew already merged it. > > We will be using it (it == node_populated_mask) later in my sysfs patch > and in the fix hugepage allocation patch. But not in the !NUMA case. So the definition of the node_populated_mask can be moved into an #ifdef CONFIG_NUMA chunk in page_alloc.c and we can have fallback functions. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org