From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 11 Jun 2007 16:17:47 -0700 (PDT) From: Christoph Lameter Subject: Re: [PATCH v6][RFC] Fix hugetlb pool allocation with empty nodes In-Reply-To: <20070611231008.GD14458@us.ibm.com> Message-ID: References: <20070611202728.GD9920@us.ibm.com> <20070611221036.GA14458@us.ibm.com> <20070611225213.GB14458@us.ibm.com> <20070611230829.GC14458@us.ibm.com> <20070611231008.GD14458@us.ibm.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Nishanth Aravamudan Cc: lee.schermerhorn@hp.com, anton@samba.org, akpm@linux-foundation.org, linux-mm@kvack.org, wli@holomorphy.com List-ID: On Mon, 11 Jun 2007, Nishanth Aravamudan wrote: > + if (nid < 0) > + nid = first_node(node_populated_map); nid == 1 means local node? Or why do we check for nid < 0? if (nid == 1) nid = numa_node_id(); ? > + do { > + page = alloc_pages_node(nid, > + GFP_HIGHUSER|__GFP_COMP|GFP_THISNODE, > + HUGETLB_PAGE_ORDER); > + nid = next_node(nid, node_populated_map); > + if (nid >= nr_node_ids) > + nid = first_node(node_populated_map); > + } while (!page && nid != start_nid); Looks good. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org