From: Christoph Lameter <clameter@sgi.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: linux-mm@kvack.org, mel@csn.ul.ie, y-goto@jp.fujitsu.com,
hugh@veritas.com
Subject: Re: memory unplug v4 [2/6] lru isolation race fix
Date: Thu, 7 Jun 2007 22:58:57 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0706072257550.28618@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20070608145818.980ec5b4.kamezawa.hiroyu@jp.fujitsu.com>
On Fri, 8 Jun 2007, KAMEZAWA Hiroyuki wrote:
> > Use get_page_unless_zero?
> >
> Oh, its better macro. thank you.
>
> Then, the whole code will be....
> ==
> if (PageLRU(page)) {
> if (get_page_unless_zero(page)) {
if (PageLRU(page) && get_page_unless_zero(page))
but I am nit picking...
> ret = 0;
> ClearPageLRU(page);
> if (PageActive(page))
> del_page_from_active_list(zone, page);
> else
> del_page_from_inactive_list(zone, page);
> list_add_tail(&page->lru, pagelist);
> }
> }
> ==
> Is this ok ?
Looks better. But it will have to pass by Hugh too I guess...
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-06-08 5:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-08 5:35 memory unplug v4 intro [0/6] KAMEZAWA Hiroyuki
2007-06-08 5:38 ` memory unplug v4 intro [1/6] migration without mm->sem KAMEZAWA Hiroyuki
2007-06-08 5:47 ` Christoph Lameter
2007-06-08 5:54 ` KAMEZAWA Hiroyuki
2007-06-08 5:57 ` Christoph Lameter
2007-06-08 6:06 ` KAMEZAWA Hiroyuki
2007-06-08 6:44 ` Christoph Lameter
2007-06-08 7:01 ` KAMEZAWA Hiroyuki
2007-06-08 7:21 ` Christoph Lameter
2007-06-08 7:25 ` KAMEZAWA Hiroyuki
2007-06-08 5:39 ` memory unplug v4 [2/6] lru isolation race fix KAMEZAWA Hiroyuki
2007-06-08 5:52 ` Christoph Lameter
2007-06-08 5:58 ` KAMEZAWA Hiroyuki
2007-06-08 5:58 ` Christoph Lameter [this message]
2007-06-08 5:40 ` memory unplug v4 intro [3/6] walk memory resources KAMEZAWA Hiroyuki
2007-06-08 5:41 ` memory unplug v4 intro [4/6] page isolation KAMEZAWA Hiroyuki
2007-06-08 13:24 ` Mel Gorman
2007-06-08 13:59 ` KAMEZAWA Hiroyuki
2007-06-08 5:43 ` memory unplug v4 intro [5/6] page offlining KAMEZAWA Hiroyuki
2007-06-08 5:43 ` memory unplug v4 intro [6/6] ia64 interface KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0706072257550.28618@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=hugh@veritas.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox